Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Ajax load groups in users page #10994

Closed
wants to merge 5 commits into from
Closed

[WIP] Ajax load groups in users page #10994

wants to merge 5 commits into from

Conversation

PVince81
Copy link
Contributor

Fixes #9201

  • The sidebar contents is now loaded with ajax.
  • Use select2 for dropdowns in the users page
  • Remove preloading of groups on the server side to avoid initial delay

CC @blizzz

@PVince81
Copy link
Contributor Author

@LukasReschke I'm not sure we want to merge this as is, it will double the load for no gain.
I'll try to put in the select2 stuff next.

@PVince81
Copy link
Contributor Author

Needs #10968 to be merged first so I can reuse the select2 utility function. I'll work on a local rebase in the meantime...

@LukasReschke
Copy link
Member

k - I'll review #10968 in the meanwhile.

@PVince81
Copy link
Contributor Author

Work in progress for select2 on a separate branch: lazyloadgroups-select2 and it already seems to work fine, apart for some layout issues.
Once #10968 is merged I'll move the changes here.

@blizzz
Copy link
Contributor

blizzz commented Sep 15, 2014

Now this is an interesting and promising approach.
You will get bonus points when you can modify fetching of $filteredUsers

$filteredUsers = $this->userManager->search($search);

to also use a limit and offset to make it faster with big user bases. Load a batch of users, if the result will still be < limit take the next batch until the limit is fulfilled or no more users are retrieved.

@PVince81
Copy link
Contributor Author

I thought of pagination but don't want to do this as part of this PR.

This one is already tricky enough, seems the select2 layout might not fit in the users page... it wraps on multiple lines by default, might need some hacking.

I'm just hoping to not have to go back to multiselect and need to extend it.

@blizzz
Copy link
Contributor

blizzz commented Sep 15, 2014

My prior comment was meant for another PR, please ignore it.

@LukasReschke
Copy link
Member

I rebased in hope that Jenkins will now be happy.

@craigpg craigpg modified the milestones: 2014-sprint-04-current, 2014-sprint-03 Sep 15, 2014
@craigpg craigpg modified the milestones: 2014-sprint-05-current, 2014-sprint-04 Sep 29, 2014
@craigpg craigpg modified the milestones: 2014-sprint-06-current, 2014-sprint-05 Oct 12, 2014
@craigpg craigpg modified the milestones: 2014-sprint-07-current, 2014-sprint-06 Oct 27, 2014
@PVince81
Copy link
Contributor Author

I rebased and added further commits that introduce select2 in the users page.

This is still WIP as it's buggy and the layout doesn't look good.

@craigpg craigpg modified the milestones: 2014-sprint-08-current, 2014-sprint-07 Nov 10, 2014
@MorrisJobke
Copy link
Contributor

As there is a blue ticket for this PR: @PVince81 What is the state of this?

@PVince81
Copy link
Contributor Author

Rebased.

But still requires #20493

@PVince81
Copy link
Contributor Author

  • TODO: make select2 disappear and transform to a regular ellipsized list. Then on hover, make the select2 box appear for editing.

@PVince81
Copy link
Contributor Author

PVince81 commented Apr 6, 2017

Not a priority right now and we managed to improve perf quite a bit already -> backlog

@felixboehm
Copy link
Contributor

felixboehm commented Apr 18, 2017

having 200 users and 1 group, ownCloud 10.0.0beta2

users?offset=0&limit=101&gid=&pattern=	status: 200	25.1 KB	1.41 s

users?offset=0&limit=202&gid=&pattern=	status: 200	48.9 KB	2.40 s

This needs some rework using the power of new account table. For 10.0.1.

@felixboehm felixboehm modified the milestones: 10.0.1, backlog Apr 18, 2017
@DeepDiver1975 DeepDiver1975 modified the milestones: 10.0.1, 10.1 May 17, 2017
@PVince81
Copy link
Contributor Author

PVince81 commented Jul 4, 2017

old, conflicts... but still wanted... the JS code of the users page is not nice

@felixboehm
Copy link
Contributor

@PVince81 development or triage?

@michaelstingl michaelstingl added p2-high Escalation, on top of current planning, release blocker and removed blue-ticket labels Jul 17, 2017
@PVince81 PVince81 modified the milestones: triage, 10.1 Jul 18, 2017
@PVince81
Copy link
Contributor Author

no time -> triage

@PVince81 PVince81 closed this Jul 19, 2017
@PVince81 PVince81 deleted the lazyloadgroups branch July 19, 2017 09:58
@PVince81
Copy link
Contributor Author

too many conflicts, needs to be redone

@lock
Copy link

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2 - Developing p2-high Escalation, on top of current planning, release blocker settings:users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users page loads all groups, make page unaccessible, i.e. not possible to manage users