[sharing] fix performance issues #11380

schiessle · 2014-10-01T15:56:13Z

Fix performance issue when the user has folders with many files and want to share a new one.

ghost · 2014-10-02T12:15:47Z

💣 Test FAILed. 💣
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser/7678/

ghost · 2014-10-06T08:03:04Z

💣 Test FAILed. 💣
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng/6/

schiessle · 2014-10-09T14:30:47Z

@owncloud-bot retest this please

PVince81 · 2014-10-09T16:34:51Z

@owncloud-bot retest this please

PVince81 · 2014-10-09T16:35:16Z

@schiesbn if this is ready for review we can have a guided code review tomorrow 😄

schiessle · 2014-10-09T17:18:50Z

yes, let's do this tomorrow

schiessle · 2014-10-10T08:24:13Z

@owncloud-bot retest this please

PVince81 · 2014-10-10T08:40:48Z

apps/files_sharing/lib/share/folder.php

+	 * @param string $shareWith with whom should the item be shared
+	 * @return array with shares
+	 */
+	public function getParents($itemSource, $shareWith = null) {


Please add a unit test for this

PVince81 · 2014-10-10T08:54:41Z

ghost · 2014-10-10T09:25:49Z

💣 Test FAILed. 💣
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng/253/

Build result: FAILURE

[...truncated 7 lines...] > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/11380/merge^{commit} # timeout=10Checking out Revision 4784fa3cb0e4c043cc294dde0fd5aa0f83f190e8 (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f 4784fa3cb0e4c043cc294dde0fd5aa0f83f190e8 > git rev-list f53496f8c74a5de89f1082eba15c77d988670ef3 # timeout=10 > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng » sqlite,vm-slave-02Configuration pull-request-analyser-ng » sqlite,vm-slave-02 is still in the queue: Waiting for next available executor on vm-slave-02Triggering pull-request-analyser-ng » pgsql,vm-slave-02Triggering pull-request-analyser-ng » mysql,vm-slave-02Triggering pull-request-analyser-ng » oci,vm-slave-02Configuration pull-request-analyser-ng » pgsql,vm-slave-02 is still in the queue: Waiting for next available executor on vm-slave-02pull-request-analyser-ng » pgsql,vm-slave-02 completed with result FAILUREpull-request-analyser-ng » mysql,vm-slave-02 completed with result FAILUREpull-request-analyser-ng » oci,vm-slave-02 completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 2 second:bomb: Test FAILed. :bomb:

schiessle · 2014-10-10T10:18:22Z

@PVince81 please try again, problem should be solved. I also added a unit test and a additional comment to explain the if statement

PVince81 · 2014-10-10T10:30:47Z

Fixes #11510

PVince81 · 2014-10-10T10:58:13Z

👍 tested, works well. Also did a bit of regression testing for sharing and didn't find any issues.

Needs a second reviewer @jnfrmarks @LukasReschke @MorrisJobke

LukasReschke · 2014-10-10T12:21:03Z

apps/files_sharing/lib/share/file.php

@@ -49,6 +49,9 @@ public function getFilePath($itemSource, $uidOwner) {
 			$path = $this->path;
 			$this->path = null;
 			return $path;
+		} else {
+			$path = \OC\Files\Filesystem::getPath($itemSource);
+			return $path;
 		}
 		return false;


As far I can see the false will never be returned here - if so, then why not remove it?

Also the PHPDoc of the interface is stating that this function can return false which is wrong now.

LukasReschke · 2014-10-10T12:24:21Z

👍 if my comments have been addressed.

ghost · 2014-10-10T13:50:34Z

💣 Test FAILed. 💣
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng/284/

Build result: FAILURE

[...truncated 7 lines...] > git fetch --tags --progress https://github.com/owncloud/core.git +refs/heads/:refs/remotes/origin/ > git config remote.origin.url https://github.com/owncloud/core.git # timeout=10 > git config remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10 > git config remote.origin.url https://github.com/owncloud/core.git # timeout=10Fetching upstream changes from https://github.com/owncloud/core.git > git fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/11380/merge^{commit} # timeout=10Checking out Revision b479c29b4aba8703f1e582de5623dd3e9fddd10a (detached) > git config core.sparsecheckout # timeout=10 > git checkout -f b479c29b4aba8703f1e582de5623dd3e9fddd10a > git rev-list a704be688799333259a1efba74a82a5edab0dad5 # timeout=10First time build. Skipping changelog. > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng » sqlite,vm-slave-02Configuration pull-request-analyser-ng » sqlite,vm-slave-02 is still in the queue: Waiting for next available executor on vm-slave-02Touchstone configurations resulted in FAILURE, so aborting...Started calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 1 second:bomb: Test FAILed. :bomb:

schiessle · 2014-10-10T13:56:27Z

Jenkins seems to be broken, but tests passed locally.

[sharing] fix performance issues

schiessle · 2014-10-10T13:59:42Z

stable7: 088879c...f4c91f0

ghost · 2014-10-10T14:48:53Z

💣 Test FAILed. 💣
Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng/287/

Build result: FAILURE

💣 Test FAILed. 💣

scrutinizer-notifier · 2014-10-10T15:14:08Z

The inspection completed: 10 new issues, 9 updated code elements

blizzz · 2014-10-16T15:20:51Z

It appears that this one broke Files view on master?
When i check out 87899db Merge pull request #11380 from owncloud/fix_performance_issue_sharing Files is empty, however
it is working with 527e1d0 try to get path from filesystem
there is nothing in between.

schiessle · 2014-10-17T15:27:18Z

527e1d0 is part of this pull request. Not sure what the difference should be.

BTW, you also need this PR: #11542, this fixes a regression from this PR. (but this affects only unit tests and non-file shares)

Also master works just fine for me... If you still have problems on master please open a issue with more information.

MorrisJobke added feature:sharing gold ticket sev2-high Type:Bug 2 - Developing labels Oct 1, 2014

schiessle force-pushed the fix_performance_issue_sharing branch from f4159b5 to a2dedbe Compare October 2, 2014 09:50

LukasReschke changed the title ~~[sharing] fix performance issues~~ [WIP] [sharing] fix performance issues Oct 4, 2014

This was referenced Oct 7, 2014

Share files/folder causes #10588

Closed

[Sharing] Not possible to share after having shared a folder #11433

Closed

schiessle force-pushed the fix_performance_issue_sharing branch 2 times, most recently from 28a36ae to 41592c2 Compare October 9, 2014 13:45

schiessle added 3 - To Review and removed 2 - Developing labels Oct 9, 2014

schiessle changed the title ~~[WIP] [sharing] fix performance issues~~ [sharing] fix performance issues Oct 9, 2014

PVince81 reviewed Oct 10, 2014
View reviewed changes

fix performance issues

3431d54

schiessle force-pushed the fix_performance_issue_sharing branch from 41592c2 to 866946f Compare October 10, 2014 10:17

PVince81 mentioned this pull request Oct 10, 2014

Unable to share files as a non admin user #11510

Closed

LukasReschke reviewed Oct 10, 2014
View reviewed changes

try to get path from filesystem

527e1d0

schiessle force-pushed the fix_performance_issue_sharing branch from 866946f to 527e1d0 Compare October 10, 2014 12:48

scolebrook force-pushed the master branch from 4a4ea1d to 9dea79e Compare October 10, 2014 13:32

schiessle added a commit that referenced this pull request Oct 10, 2014

Merge pull request #11380 from owncloud/fix_performance_issue_sharing

87899db

[sharing] fix performance issues

schiessle merged commit 87899db into master Oct 10, 2014

schiessle deleted the fix_performance_issue_sharing branch October 10, 2014 13:56

lock bot locked as resolved and limited conversation to collaborators Aug 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[sharing] fix performance issues #11380

[sharing] fix performance issues #11380

schiessle commented Oct 1, 2014

ghost commented Oct 2, 2014

ghost commented Oct 6, 2014

schiessle commented Oct 9, 2014

PVince81 commented Oct 9, 2014

PVince81 commented Oct 9, 2014

schiessle commented Oct 9, 2014

schiessle commented Oct 10, 2014

PVince81 Oct 10, 2014

PVince81 commented Oct 10, 2014

ghost commented Oct 10, 2014

schiessle commented Oct 10, 2014

PVince81 commented Oct 10, 2014

PVince81 commented Oct 10, 2014

LukasReschke Oct 10, 2014

LukasReschke Oct 10, 2014

LukasReschke commented Oct 10, 2014

ghost commented Oct 10, 2014

schiessle commented Oct 10, 2014

schiessle commented Oct 10, 2014

ghost commented Oct 10, 2014

scrutinizer-notifier commented Oct 10, 2014

blizzz commented Oct 16, 2014

schiessle commented Oct 17, 2014

[sharing] fix performance issues #11380

[sharing] fix performance issues #11380

Conversation

schiessle commented Oct 1, 2014

ghost commented Oct 2, 2014

ghost commented Oct 6, 2014

schiessle commented Oct 9, 2014

PVince81 commented Oct 9, 2014

PVince81 commented Oct 9, 2014

schiessle commented Oct 9, 2014

schiessle commented Oct 10, 2014

PVince81 Oct 10, 2014

Choose a reason for hiding this comment

PVince81 commented Oct 10, 2014

ghost commented Oct 10, 2014

Build result: FAILURE

schiessle commented Oct 10, 2014

PVince81 commented Oct 10, 2014

PVince81 commented Oct 10, 2014

LukasReschke Oct 10, 2014

Choose a reason for hiding this comment

LukasReschke Oct 10, 2014

Choose a reason for hiding this comment

LukasReschke commented Oct 10, 2014

ghost commented Oct 10, 2014

Build result: FAILURE

schiessle commented Oct 10, 2014

schiessle commented Oct 10, 2014

ghost commented Oct 10, 2014

Build result: FAILURE

scrutinizer-notifier commented Oct 10, 2014

blizzz commented Oct 16, 2014

schiessle commented Oct 17, 2014