[WIP] new s3 scanner #11712
Closed
[WIP] new s3 scanner #11712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butonic
force-pushed
the
files_external_scan_all_files
branch
from
44c2073
to
0bde0fb
Compare
|
This cannot be rebased at the moment because it's broken due to #11714 |
butonic
force-pushed
the
files_external_scan_all_files
branch
from
0bde0fb
to
0b6f464
Compare
This was referenced Oct 27, 2014
|
@icewind1991 what do you think ? |
|
WIP -> OC8.1 |
|
@butonic what shall we do with this ? |
|
I am asking you that:
|
|
moving this to 8.2 - touching files_external is out of scope for 8.1 |
|
cc @icewind1991 @schiesbn @PVince81 |
WIP -> OC9.0 |
|
@butonic can we get this out of the WIP state? THX |
|
Closing due to lack of activity/feedback. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented a S3 scanner that iterates over all objects in a bucket and updates the filecache so we have an up to date mtime for syncing. It fixes #8633 when the file scan for the user is triggered periodically.
Keep in mind that amazon s3 users pay for the traffic, so don't execute it every 5 min.
It is still WIP as the Scanner became S3 specific and I need opinions on the approach. cc @icewind1991 @schiesbn @PVince81
I Still think this is the best solution. Also: browsing the web interface ALWAYS makes a trip to the bucket. we could use that to update the filecache as well, but it only helps if someone browses the directory tree.