Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unify count filters and introduce display name attribute detection #11837

Merged
merged 14 commits into from
Nov 24, 2014
Merged

unify count filters and introduce display name attribute detection #11837

merged 14 commits into from
Nov 24, 2014

Commits on Nov 20, 2014

  1. detect user display name attribute and return user count depending on… 

    … its presence
    @blizzz
    blizzz committed Nov 20, 2014
    Configuration menu
    Copy the full SHA
    cb3af1d View commit details
    Browse the repository at this point in the history

  2. consolidate user count filter in wizard and user back end

    @blizzz
    blizzz committed Nov 20, 2014
    Configuration menu
    Copy the full SHA
    f725cc6 View commit details
    Browse the repository at this point in the history

  3. detectors (email, displayname..) are now started in one place, trigge… 

    …red from only 2 places. more reliable structure and flow, saves requests
    @blizzz
    blizzz committed Nov 20, 2014
    Configuration menu
    Copy the full SHA
    71944a5 View commit details
    Browse the repository at this point in the history

  4. to reassure that selected attributes still work, do not count all mat… 

    …ching entries but limit it to 1 in order to make it faster
    @blizzz
    blizzz committed Nov 20, 2014
    Configuration menu
    Copy the full SHA
    f9b4f5f View commit details
    Browse the repository at this point in the history

  5. a corrected email attribute needs to be saved, not only returned

    @blizzz
    blizzz committed Nov 20, 2014
    Configuration menu
    Copy the full SHA
    4a3fe42 View commit details
    Browse the repository at this point in the history

  6. JS doc

    @blizzz
    blizzz committed Nov 20, 2014
    Configuration menu
    Copy the full SHA
    c9e8656 View commit details
    Browse the repository at this point in the history

  7. this happens already before counting, no need anymore

    @blizzz
    blizzz committed Nov 20, 2014
    Configuration menu
    Copy the full SHA
    d8bb8af View commit details
    Browse the repository at this point in the history

  8. use underscore.js for undefined checks

    @blizzz
    blizzz committed Nov 20, 2014
    Configuration menu
    Copy the full SHA
    0e6d471 View commit details
    Browse the repository at this point in the history

  9. better readbility, no effective changes

    @blizzz
    blizzz committed Nov 20, 2014
    Configuration menu
    Copy the full SHA
    031d6c1 View commit details
    Browse the repository at this point in the history

  10. phpdoc and mixed up letters

    @blizzz
    blizzz committed Nov 20, 2014
    Configuration menu
    Copy the full SHA
    6b6147d View commit details
    Browse the repository at this point in the history

  11. trigger count on the correct filter

    @blizzz
    blizzz committed Nov 20, 2014
    Configuration menu
    Copy the full SHA
    b5e707b View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2014

  1. fix counting when ldapPagingSize is 0

    @blizzz
    blizzz committed Nov 21, 2014
    Configuration menu
    Copy the full SHA
    c07c338 View commit details
    Browse the repository at this point in the history

  2. make updateCount work properly with new xp'd mode as well as without

    @blizzz
    blizzz committed Nov 21, 2014
    Configuration menu
    Copy the full SHA
    503de94 View commit details
    Browse the repository at this point in the history

  3. make scrutinizer happier and always count users on assisted mode, eve… 

    …n with xp'ed mode (would be a regression otherwise)
    @blizzz
    blizzz committed Nov 21, 2014
    Configuration menu
    Copy the full SHA
    9aef83b View commit details
    Browse the repository at this point in the history