-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show warning when invalid user was passed #12175
Conversation
544f350
to
91bf430
Compare
👍 makes sense |
LGTM 👍 |
Tests failing on master, let's wait for them to be fixed. |
That test will be fixed when #12085 is discussed and merged... |
... let skip the test for now ... - creating PR. |
Sometimes there are bugs that cause setupFS() to be called for non-existing users. Instead of failing hard and breaking the instance, this fix simply logs a warning.
91bf430
to
c941c3f
Compare
The inspection completed: 1 updated code elements |
@owncloud-bot Retest this please. |
Jenkins and force push... I'll submit a separate PR |
Superseded by #12290 |
@karlitschek @jnfrmarks I'd like to get this backported. This issue has been reported at least 4 times already, with at least three different causes / code paths:
Even though the root cause might not be critical in itself, the code path it follows leads to this exception, which itself leads to feature breakage. The fix mitigates that problem by logging a warning instead of throwing and exception, making OC work again. |
Please backport. Thanks |
stable7: f64c6c9 @jnfrmarks reproduction steps are same like #12131 |
Sometimes there are bugs that cause setupFS() to be called for
non-existing users. Instead of failing hard and breaking the instance,
this fix simply logs a warning.
This is mostly a protection against other bugs. This code path was already triggered by three different bugs (from which some were fixed already).
Please review @icewind1991 @schiesbn @Xenopathic