Add support for Raw files previews #13652

oparoz · 2015-01-24T23:05:25Z

Solution for

#13650
owncloud-archive/apps#439
owncloud-archive/apps#1113

Supported formats:

Sony Alpha RAW .arw
Canon RAW 2 .cr2
Digital Camera Raw .dcr
Digital Negative .dng
EPSON RAW .erf
Intelligent Image Quality RAW .iiq
Kodak DC40/DC50 RAW .kdc
Kodak DC25 RAW .k25
Nikon RAW .nef
Mamiya RAW .mef
Olympus RAW .orf
Panasonic RAW .rw2
PENTAX RAW .pef
Fujifilm RAW .raf
Sony RAW File .srf .sr2
SIGMA RAW .xrf

Requirements

ImageMagick
ufraw as an ImageMagick delegate for DNG
ufraw-batch must be reachable from PHP
PR Keep the extension in temp files #13654, which is a fix for \OC_Helper::tmpFile can break Imagemagick #12282
A gallery app which supports all media types supported by ownCloud

nickvergessen · 2015-01-26T09:30:10Z

lib/private/preview/raw.php

+	public function getMimeType() {
+		return '/image\/x-dcraw/';
+	}
+}


oparoz · 2015-02-11T17:26:55Z

Excellent website with samples to test with
http://www.rawsamples.ch/

oparoz · 2015-02-12T03:05:11Z

Looking at https://ci.owncloud.org/job/pull-request-analyser-ng-simple/9268/label=SLAVE/console , I don't think the repair tests were executed.

nickvergessen · 2015-02-24T13:21:42Z

lib/private/preview/image.php

@@ -13,7 +13,7 @@ class Image extends Provider {
 	 * {@inheritDoc}
 	 */
 	public function getMimeType() {
-		return '/image\/(?!tiff$)(?!svg.*).*/';
+		return '/image\/(?!x-dcraw$)(?!tiff$)(?!svg.*).*/';


this looks wrong to me.
Seems to only work for svg as intended: https://regex101.com/r/qQ4bO5/1

You need to test one at a time (like the Preview class does) and you should see that it works.

MorrisJobke · 2015-03-11T13:22:26Z

@DeepDiver1975 @nickvergessen Same as in #13648 (comment) ?

MorrisJobke · 2015-03-11T14:59:32Z

lib/repair/repairmimetypes.php

@@ -190,5 +214,9 @@ public function run() {
 		if ($this->fixPostscriptMimeType()) {
 			$this->emit('\OC\Repair', 'info', array('Fixed Postscript mime types'));
 		}
+
+		if ($this->introduceRawMimeType()) {
+			$this->emit('\OC\Repair', 'info', array('Fixed Postscript mime types'));


Copy and paste error?

Good eye :)

MorrisJobke · 2015-03-11T17:23:13Z

@owncloud-bot retest this please

ghost · 2015-03-11T17:44:07Z

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/10375/

Build result: FAILURE

[...truncated 13 lines...] > git config --local --remove-section credential # timeout=10 > git config remote.origin.url https://github.com/owncloud/core.git # timeout=10 > git config --add remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10 > git config remote.origin.url https://github.com/owncloud/core.git # timeout=10Fetching upstream changes from https://github.com/owncloud/core.gitusing GIT_SSH to set credentials using .gitcredentials to set credentials > git config --local credential.helper store --file=/tmp/git4157415401091231901.credentials # timeout=10 > git -c core.askpass=true fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git config --local --remove-section credential # timeout=10 > git rev-parse refs/remotes/origin/pr/13652/merge^{commit} # timeout=10 > git rev-parse refs/remotes/origin/origin/pr/13652/merge^{commit} # timeout=10Checking out Revision b475b157dcaa1f99b826c0a71429254e2cd88761 (refs/remotes/origin/pr/13652/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f b475b157dcaa1f99b826c0a71429254e2cd88761 > git rev-list b475b157dcaa1f99b826c0a71429254e2cd88761 # timeout=10 > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » SLAVEpull-request-analyser-ng-simple » SLAVE completed with result FAILURESetting status of 20ff83b3c60257a5234953de28f1d9dd3fdc9053 to FAILURE with url https://ci.owncloud.org/job/pull-request-analyser-ng-simple/10375/ and message: Merged build finished.
Test FAILed.

oparoz · 2015-03-13T11:37:58Z

Failing tests are unrelated

nickvergessen · 2015-03-13T11:46:11Z

@owncloud-bot retest this please

ghost · 2015-03-13T11:49:39Z

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/10427/

Build result: FAILURE

[...truncated 14 lines...] > git config remote.origin.url https://github.com/owncloud/core.git # timeout=10 > git config --add remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10 > git config remote.origin.url https://github.com/owncloud/core.git # timeout=10Fetching upstream changes from https://github.com/owncloud/core.gitusing GIT_SSH to set credentials using .gitcredentials to set credentials > git config --local credential.helper store --file=/tmp/git3833776074722769109.credentials # timeout=10 > git -c core.askpass=true fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git config --local --remove-section credential # timeout=10 > git rev-parse refs/remotes/origin/pr/13652/merge^{commit} # timeout=10 > git rev-parse refs/remotes/origin/origin/pr/13652/merge^{commit} # timeout=10Checking out Revision 2cf5304d247199328ef4701bcfe40c46cc19762e (refs/remotes/origin/pr/13652/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 2cf5304d247199328ef4701bcfe40c46cc19762e > git rev-list b475b157dcaa1f99b826c0a71429254e2cd88761 # timeout=10First time build. Skipping changelog. > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » SLAVEpull-request-analyser-ng-simple » SLAVE completed with result FAILURESetting status of 20ff83b3c60257a5234953de28f1d9dd3fdc9053 to FAILURE with url https://ci.owncloud.org/job/pull-request-analyser-ng-simple/10427/ and message: Merged build finished.
Test FAILed.

Including media type migration and tests Solutions for #13650 owncloud-archive/apps#439 owncloud-archive/apps#1113 Supported formats: Sony Alpha RAW .arw Canon RAW 2 .cr2 Digital Camera Raw .dcr Digital Negative .dng EPSON RAW .erf Intelligent Image Quality RAW .iiq Kodak DC40/DC50 RAW .kdc Kodak DC25 RAW .k25 Nikon RAW .nef Mamiya RAW .mef Olympus RAW .orf Panasonic RAW .rw2 PENTAX RAW .pef Fujifilm RAW .raf Sony RAW File .srf .sr2 SIGMA RAW .xrf

scrutinizer-notifier · 2015-03-13T13:03:09Z

A new inspection was created.

ghost · 2015-03-13T13:04:57Z

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/10436/

Build result: FAILURE

[...truncated 14 lines...] > git config remote.origin.url https://github.com/owncloud/core.git # timeout=10 > git config --add remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10 > git config remote.origin.url https://github.com/owncloud/core.git # timeout=10Fetching upstream changes from https://github.com/owncloud/core.gitusing GIT_SSH to set credentials using .gitcredentials to set credentials > git config --local credential.helper store --file=/tmp/git4232959675771617654.credentials # timeout=10 > git -c core.askpass=true fetch --tags --progress https://github.com/owncloud/core.git +refs/pull/:refs/remotes/origin/pr/ > git config --local --remove-section credential # timeout=10 > git rev-parse refs/remotes/origin/pr/13652/merge^{commit} # timeout=10 > git rev-parse refs/remotes/origin/origin/pr/13652/merge^{commit} # timeout=10Checking out Revision a64013628ec81fe8886cff6ad709e4d4ae58cb72 (refs/remotes/origin/pr/13652/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f a64013628ec81fe8886cff6ad709e4d4ae58cb72 > git rev-list 2cf5304d247199328ef4701bcfe40c46cc19762e # timeout=10First time build. Skipping changelog. > git remote # timeout=10 > git submodule init # timeout=10 > git submodule sync # timeout=10 > git config --get remote.origin.url # timeout=10 > git submodule update --init --recursiveTriggering pull-request-analyser-ng-simple » SLAVEpull-request-analyser-ng-simple » SLAVE completed with result FAILURESetting status of d0d9a1f to FAILURE with url https://ci.owncloud.org/job/pull-request-analyser-ng-simple/10436/ and message: Merged build finished.
Test FAILed.

oparoz · 2015-03-13T13:09:08Z

So why can't the bot even merge this PR?

LukasReschke · 2015-03-13T13:12:48Z

Bug in the CI plugin. Either retry or if that does not work create a new PR :-(

oparoz · 2015-03-13T13:17:30Z

;(

I just did a rebase and it failed, so I guess I'll have to create a fresh one... Thanks!

nickvergessen · 2015-03-13T13:49:08Z

I just did a rebase and it failed, so I guess I'll have to create a fresh one... Thanks!

Before pushing again to a branch, make sure to wait until jenkins reported back

oparoz · 2015-03-13T13:52:04Z

Yep. I noticed yesterday that my default setting for push was not set to simple, so sometimes, changes were pushed to side branches as well, killing jenkins in the process if he was already looking at that branch.

So if that every happens, then it just kills the branch?

scrutinizer-notifier · 2015-03-13T14:01:18Z

The inspection completed: 2 new issues, 4 updated code elements

MorrisJobke · 2015-03-13T14:05:29Z

@oparoz You can simply close this PR and open a new one without deleting the branch - everything right on github. This should solve the Jenkins plugin problem ;)

oparoz · 2015-03-13T14:12:39Z

New PR #14878
Let's hope this works

MorrisJobke · 2015-03-13T14:14:42Z

@oparoz Looks good so far: https://ci.owncloud.org/job/pull-request-analyser-ng-simple/10443/label=SLAVE/console :)

oparoz · 2015-03-13T14:17:35Z

😌

This was referenced Jan 24, 2015

raw support owncloud-archive/apps#1113

Closed

raw file support in file viewer, pictures and gallery owncloud-archive/apps#439

Open

Supporting the Raw image format (digital negatives) #13650

Closed

LukasReschke added this to the 8.1-next milestone Jan 25, 2015

nickvergessen added the feature:previews label Jan 26, 2015

nickvergessen reviewed Jan 26, 2015
View reviewed changes

lib/private/preview/raw.php

public function getMimeType() {

return '/image\/x-dcraw/';

}

}

Copy link

Contributor

nickvergessen Jan 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

oparoz added the 3 - To Review label Jan 26, 2015

oparoz self-assigned this Jan 26, 2015

jancborchardt added the enhancement label Jan 28, 2015

LukasReschke added 2 - Developing and removed 3 - To Review labels Feb 24, 2015

LukasReschke changed the title ~~Add support for Raw files previews~~ [WIP] Add support for Raw files previews Feb 24, 2015

nickvergessen reviewed Feb 24, 2015
View reviewed changes

oparoz changed the title ~~[WIP] Add support for Raw files previews~~ Add support for Raw files previews Feb 24, 2015

oparoz added 3 - To Review and removed 2 - Developing labels Feb 24, 2015

MorrisJobke reviewed Mar 11, 2015
View reviewed changes

MorrisJobke added 2 - Developing 3 - To Review and removed 3 - To Review 2 - Developing labels Mar 11, 2015

oparoz closed this Mar 13, 2015

MorrisJobke removed this from the 8.1-current milestone Mar 13, 2015

oparoz mentioned this pull request Mar 13, 2015

Add support for Raw files previews #14878

Closed

michaelstingl mentioned this pull request Jul 5, 2018

[Previews] Image gallery owncloud/ios-app#85

Closed

9 tasks

lock bot locked as resolved and limited conversation to collaborators Aug 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Raw files previews #13652

Add support for Raw files previews #13652

oparoz commented Jan 24, 2015

nickvergessen Jan 26, 2015

oparoz commented Feb 11, 2015

oparoz commented Feb 12, 2015

nickvergessen Feb 24, 2015

oparoz Feb 24, 2015

MorrisJobke commented Mar 11, 2015

MorrisJobke Mar 11, 2015

oparoz Mar 11, 2015

MorrisJobke commented Mar 11, 2015

ghost commented Mar 11, 2015

oparoz commented Mar 13, 2015

nickvergessen commented Mar 13, 2015

ghost commented Mar 13, 2015

scrutinizer-notifier commented Mar 13, 2015

ghost commented Mar 13, 2015

oparoz commented Mar 13, 2015

LukasReschke commented Mar 13, 2015

oparoz commented Mar 13, 2015

nickvergessen commented Mar 13, 2015

oparoz commented Mar 13, 2015

scrutinizer-notifier commented Mar 13, 2015

MorrisJobke commented Mar 13, 2015

oparoz commented Mar 13, 2015

MorrisJobke commented Mar 13, 2015

oparoz commented Mar 13, 2015

Add support for Raw files previews #13652

Add support for Raw files previews #13652

Conversation

oparoz commented Jan 24, 2015

Solution for

Supported formats:

Requirements

nickvergessen Jan 26, 2015

Choose a reason for hiding this comment

oparoz commented Feb 11, 2015

oparoz commented Feb 12, 2015

nickvergessen Feb 24, 2015

Choose a reason for hiding this comment

oparoz Feb 24, 2015

Choose a reason for hiding this comment

MorrisJobke commented Mar 11, 2015

MorrisJobke Mar 11, 2015

Choose a reason for hiding this comment

oparoz Mar 11, 2015

Choose a reason for hiding this comment

MorrisJobke commented Mar 11, 2015

ghost commented Mar 11, 2015

Build result: FAILURE

oparoz commented Mar 13, 2015

nickvergessen commented Mar 13, 2015

ghost commented Mar 13, 2015

Build result: FAILURE

scrutinizer-notifier commented Mar 13, 2015

ghost commented Mar 13, 2015

Build result: FAILURE

oparoz commented Mar 13, 2015

LukasReschke commented Mar 13, 2015

oparoz commented Mar 13, 2015

nickvergessen commented Mar 13, 2015

oparoz commented Mar 13, 2015

scrutinizer-notifier commented Mar 13, 2015

MorrisJobke commented Mar 13, 2015

oparoz commented Mar 13, 2015

MorrisJobke commented Mar 13, 2015

oparoz commented Mar 13, 2015