Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect mod_unique_id and refactor OC_Request::getRequestId #13973

Merged
merged 1 commit into from
Feb 9, 2015

Commits on Feb 9, 2015

  1. Respect mod_unique_id and refactor OC_Request::getRequestId

    When `mod_unique_id` is enabled the ID generated by it will be used for logging. This allows for correlation of the Apache logs and the ownCloud logs.
    
    Testplan:
    
    - [ ] When `mod_unique_id` is enabled the request ID equals the one generated by `mod_unique_id`.
    - [ ] When `mod_unique_id` is not available the request ID is a 20 character long random string
    - [ ] The generated Id is stable over the lifespan of one request
    
    Changeset looks a little bit larger since I had to adjust every unit test using the HTTP\Request class for proper DI.
    
    Fixes #13366
    LukasReschke committed Feb 9, 2015
    Configuration menu
    Copy the full SHA
    770fa76 View commit details
    Browse the repository at this point in the history