Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the css of the topbar to not be wider then the screen. #1430

Closed
wants to merge 2 commits into from

Conversation

icewind1991
Copy link
Contributor

Preiviously the topbar extended past the right edge of the screen, which made positioning of elements on the right edge of the topbar more difficult.

With this patch you can just use float:right;

Some apps using the topbar might need some adjustments.

@jancborchardt @tanghus

@tanghus
Copy link
Contributor

tanghus commented Feb 3, 2013

👍 Look OK to me, but it will give a merge conflict with #1428 in styles.css

@tanghus
Copy link
Contributor

tanghus commented Feb 3, 2013

On second thought I'm not sure about the changes to styles.css. Keep the box-sizing but drop the left-padding and use position:relative instead - or merge #1428 ;)

@icewind1991
Copy link
Contributor Author

using position: relative won't fix the width issue though, only the positioning.

@tanghus
Copy link
Contributor

tanghus commented Feb 3, 2013

Yes it will, because the sizing is done according to it's relative position instead of the window. Try it ;)

@icewind1991
Copy link
Contributor Author

On Sunday 03 February 2013 15:48:03 Thomas Tanghus wrote:

Yes it will, because the sizing is done according to it's relative position
instead of the window. Try it ;)

Right, I forgot that it's parent element was already sized correctly.

  • Robin Appelman

@icewind1991 icewind1991 closed this Feb 4, 2013
@LukasReschke LukasReschke deleted the controls_css branch March 25, 2014 20:15
@lock lock bot locked as resolved and limited conversation to collaborators Aug 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants