Disallow path traversals in file view #14342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refer to this link for build results (access rights to CI server needed): |
| public function filemtime($path) { | ||
| return $this->basicOperation('filemtime', $path); | ||
| } | ||
|
|
||
| /** | ||
| * @param $path |
|
Makes sense 👍 |
This prevents a misusage of \OC\Files\View by calling it with user-supplied input. In such cases an exception is now thrown.
LukasReschke
force-pushed
the
disallow-path-traversals-in-file-view
branch
from
dad22ce
to
46ca0fa
Compare
|
@nickvergessen Adjusted. |
|
Refer to this link for build results (access rights to CI server needed): |
|
The inspection completed: 27 new issues, 2 updated code elements |
|
👍 |
DeepDiver1975
added a commit
that referenced
this pull request
Feb 19, 2015
…ile-view Disallow path traversals in file view
|
@LukasReschke I assume we want this on all stable branches? |
|
Not quite sure about this as it is "just" an hardening and you never know which third-party apps rely on which behaviour. Our shipped apps should work okay though. I'd say we keep this for 8.1 for now. - With a 3 month release schedule this will reach the users anyways soon :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a misusage of
\OC\Files\Viewby calling it with user-supplied input. In such cases an exception is now thrown.Also I added some basic PHPDocs to that class as my IDE was crying "FIX ME" ;-)
cc @icewind1991 Please review