[sqlite] Use an atomic implementation on sqlite for insertIfNotExist() + use it in the file cache ... #14734
Conversation
DeepDiver1975
changed the title
|
The inspection completed: No new issues |
|
Refer to this link for build results (access rights to CI server needed): |
DeepDiver1975
changed the title
|
Refer to this link for build results (access rights to CI server needed): |
|
I can confirm that this patch fixes all the problems I saw. No internal server errors any more 🍻 |
|
👍 of course. |
|
👍 |
[sqlite] Use an atomic implementation on sqlite for insertIfNotExist() + use it in the file cache ...
|
how to apply this patch? |
This patch is also part of 8.0.2 - which will be released tomorrow |
Without this files with a ` (backtick) in the beginning of the filenames where simply not correctly referenced as the ` got removed. This can lead to all possible havoc situations. Should get backported to stable8 and in future we might consider if it is really worth to backport such changes when it is just for SQLite 🙈 Regression of #14734
|
Is this fix valid for OC7 as well? |
no - 8.0.3 will contain this fix. there are no plans to backport this to oc7 |
|
Thank you for your fast reply. Or can i just replace the 3 files in my setup? Will this work or will this break my installation? At the moment we have allot of Duplicate Entry in oc_filecache errors in our System but I can't update to oc8. |
No - this will no help at all - this change was only the foundation to fix the issue. The full fix is spread amongst multiple patches. |
@dragotin can you put this on your failing instance? THX
@PVince81 @icewind1991 please review
insertIfNotExist() is now used in the file cache to avoid integrity constraint violations. Let's see ...