[WIP] Experiment with moving the share dropdown to a sidebar

[jancborchardt]

IMPORTANT This is only to be understood as a stupid mockup. To make this work nicely we need some deep underlying code changes. cc @DeepDiver1975

First testing of a sidebar instead of dropdown. Some things missing:

• VERY IMPORTANT: Add file thumbnail & name on top so you know which file this is about
• we could even make the thumbnail a bit bigger, especially useful for pictures and to make @dragotin happy ;D
• animations to slide it in nicely from the right and slide it out again
• a switcher on top for Versions & Sharing. For folders no switcher is needed as there are no versions.
• add a close button on the top right
• on clicking outside it, close it instead of performing any other action
• add a menu for the actions: Improve mobile interface: ability to use all file actions, remove need to hover #12081

In the future:

• show more info about the file ownCloud Right Side File / Folder Details #16308
• include the activity stream for the file
• in that activity stream, integrate the versions directly
• also in the activity stream, integrate the ability to leave and read comments on the file. Ref Adding comments to right sidebar for files & folders #16328

Before:

After:

What do you think @MTRichards @karlitschek @owncloud/designers?

[scrutinizer-notifier]

A new inspection was created.

[libasys]

And what is with the other apps, which uses the share dialog like calendar, tasks, etc! This is nice if you have a list, but other apps have a app dialog on the right sidebar like the calendar app! Should this css addition not better a part of a dev of an app? The css part of the dropdown is easy to manipulate!

[jancborchardt]

This is nice if you have a list, but other apps have a app dialog on the right sidebar like the calendar app!

@libasys no app has something on the right side. The calendar app only has a sidebar on the left and the rest is the calendar display. (As it should be – lots of people even complain about the sidebar being there all the time.)

[PVince81]

CC @rullzer

[jancborchardt]

Good and important note by @libasys: What if an app (like the Calendar, for calendars) has a sharing symbol in the left sidebar. Then it's a bit confusing that the dialog opens on the right ... well I guess we have to experiment.

[PVince81]

Maybe there should be an API or container containing the sharing fields, and any app can embed them wherever they like, whether dropdown or sidebar.

@jancborchardt will the sidebar be "on top of" the file list ? Or will the file list width shrink to fit ?

I'm also a bit worried that it will clutter the UI too much, and then in the end there is only a little window left in the middle for the file list. But I can't think of anything better. I do like the idea of having a side with file info.

Maybe another alternative would be to embed it as a panel into the left sidebar ? But that might make it confusing for the user to understanding the hierarchy of panels.

[DeepDiver1975]

And what is with the other apps, which uses the share dialog like calendar, tasks, etc! This is nice if you have a list, but other apps have a app dialog on the right sidebar like the calendar app! Should this css addition not better a part of a dev of an app? The css part of the dropdown is easy to manipulate!

I'd suggest to leave the UI element with the individual apps - this gives everybody the freedom to customize the UI as desired. Once we have a fully functional OCS sharing api in place this should be the only common used interface between any app and core.

Re-using the sharing drop down for files in gallery looks a bit strange anyhow (at least loong time back as I had a closer looks 🙈 )

[DeepDiver1975]

I'd suggest to leave the UI element with the individual apps - this gives everybody the freedom to customize the UI as desired.

Especially because different apps use different js frameworks and templating mechanisms ....

[jancborchardt]

Relaying from what @libasys said in IRC:

hi i am more and more fan of the share dialog on the right side, i have upgraded all my apps and now working with dialog on the right side!

:)

[oparoz]

Make the default a right sidebar, but make the UI optional. That way it can be very quick to implement for devs if they don't mind the right sidebar, but if they want to implement their own dropdown or sidebar, then they can still get the content via a simple call.

[jancborchardt]

@oparoz the plan is to have the ability for apps to register elements in the sidebar. :) We should keep the interface consistent, so I would say it’s better to get rid of the dropdowns. It would also look better for the album info pane in Gallery+ for example.

[oparoz]

For Gallery, the sidebar makes sense and could help remove some buttons, but as mentioned earlier by others, it might not always make sense to get the full UI in an app, so there should be a way for those to get all the inner divs only.

[PVince81]

Let's follow up the discussion in this ticket: #16308

This PR was only experimental to see how it looks like and will not be used directly.

[PVince81]

See #17656 for the actual implementation.

I will tick the checkboxes in the original post for the stuff that is done there already.

[jancborchardt]

The big concern I still have is the positioning of the sidebar. When you initiate the sharing from the left navigation (like when sharing a Calendar), it seems very strange to open a sidebar to the right.

What do you think @owncloud/designers @MorrisJobke @PVince81 @MTRichards @karlitschek @libasys?

[jancborchardt]

Closing in favor of the work already done and #18185 – @blizzz make sure to transfer the layout as close as possible so we can build on that. :)