New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable8] backport 13740 and 15606 #16456
Conversation
backport is fine 👍 |
Refer to this link for build results (access rights to CI server needed): |
we need testing power here @rperezb THX |
@DeepDiver1975 thanks for the reminder, yes, this is on our list, @davitol is currently checking |
@davitol I just tested if it still works with an LDAP instance. |
@davitol For me the groupID shows up. :( |
Got it ... it is only there in the second try.
|
@cmonteroluque Either there volunteers somebody to debug this race condition or we need to delay this :( I don't think that I have time tomorrow to debug this properly. |
@cmonteroluque The blue ticket refers to a stable7 instance (where this is already fixed) So I'm fine with moving this to 8.0.5 and wait for @blizzz |
cc @DeepDiver1975 regarding release planing |
agreed |
The problem with this PR is that it is present in master and stable7 already and the issue, why it is not merged is #16626. Should we merge this now, because it is better to have a working group selection in stable8 for AD too, that has a known bug, but we know the workaround too. Or should we ship the broken behaviour in stable7 and master only and wait for the proper fix of this problem and then port the stuff from this stable8 branch to stable7 and master? cc @DeepDiver1975 @cmonteroluque |
This is what I observe:
The same happens when deselecting a group. It looks like the raw filter simply doesn't refresh properly, unless collapsed and expanded again. Also, if you expand too early while the spinners are still turning, there is a chance to mess it up too. |
@MorrisJobke I've tested again in stable8 -> "8.0.4.2","versionstring":"8.0.4","edition":"Enterprise" |
Did it work? It's too blurry to read anything :( |
No, it didn't 😿 |
@MorrisJobke @blizzz looks like we need to get our hands dirty again -> moved to 8.0.6 |
To reassure, did you use stable8 branch or this one here (stable8-backport-13740-and-15606)? |
@blizzz Both of them with the same behaviour |
…he specific groups as primary set.
5385262
to
4253838
Compare
rebased |
👍 It works |
🎆 |
[stable8] backport 13740 and 15606
Backport of #13740 and #15606 (because the latter is a followup of the previous one)
Fixes #12190 and fixes #13533
How to test?
(&(|(objectclass=person))(|(|((memberof=CN=Domain Users,CN=Users,DC=madder,DC=owncloud,DC=bzoc)(primaryGroupID=513)))(|((memberof=CN=Wolfpack 8,OU=packs,DC=madder,DC=owncloud,DC=bzoc)(primaryGroupID=968988)
(2 selected groups)(primaryGroupID=XXX)
part should not show up!@craigpg @sbelov1 @bboule @jnfrmarks @plastilincheg @rjaeckel @gig13 Please test. I tested this with an LDAP instance and all works like before and no errors are logged.
This is my 👍 for this, because I only cherry picked the commits of @blizzz who is on vacation.