Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a hook to integrate sharing password verification #17838

Merged
merged 2 commits into from Jul 24, 2015

Conversation

DeepDiver1975
Copy link
Member

@schiesbn did I catch all password changing and setting operations?

@karlitschek @cmonteroluque @MTRichards this is the core part of the password policy integration

#17827 is required as well for better user feedback in case the password verification fails.

@DeepDiver1975 DeepDiver1975 added this to the 8.2-current milestone Jul 23, 2015
@karlitschek
Copy link
Contributor

looks good 👍 please backport as discussed.

@MTRichards
Copy link
Contributor

Excellent. This would allow an app to be built to implement the custom policy, right?

@CaptionF just fyi, for your reference - a password policy enforcement hook, step one.

@schiessle
Copy link
Contributor

btw, while you are on it, please also fix the wrong description of the setPassword() method. Thanks!

beside that it looks good 👍

@ghost
Copy link

ghost commented Jul 23, 2015

🚀 Test PASSed.🚀
chuck

@scrutinizer-notifier
Copy link

A new inspection was created.

@ghost
Copy link

ghost commented Jul 23, 2015

🚀 Test PASSed.🚀
chuck

@rullzer
Copy link
Contributor

rullzer commented Jul 23, 2015

I assume we do not have a way to force only 1 listener to a hook? Else we need to watch out for user error if multiple listeners try to verify the password.

Otherwise looking good! 👍

DeepDiver1975 added a commit that referenced this pull request Jul 24, 2015
Use a hook to integrate sharing password verification
@DeepDiver1975 DeepDiver1975 merged commit 1124473 into master Jul 24, 2015
@DeepDiver1975 DeepDiver1975 deleted the sharing-password-policy-master branch July 24, 2015 14:47
@lock lock bot locked as resolved and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants