Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving mysql setup code over to Doctrine #17963

Merged
merged 4 commits into from Jul 30, 2015
Merged

Moving mysql setup code over to Doctrine #17963

merged 4 commits into from Jul 30, 2015

Conversation

DeepDiver1975
Copy link
Member

fixes #11788

@DeepDiver1975 DeepDiver1975 added this to the 8.2-current milestone Jul 29, 2015
@karlitschek
Copy link
Contributor

👍

@DeepDiver1975
Moving mysql setup code over to Doctrine
114f128
@DeepDiver1975
- more injection
c3cac88 
- less static calls
- use params on sql queries
- handle sql exception on database and user creation gracefully
@DeepDiver1975 DeepDiver1975 force-pushed the remove-derecated-mysql-functions branch from 38aa976 to c3cac88 Compare July 29, 2015 22:04
@DeepDiver1975 DeepDiver1975 mentioned this pull request Jul 29, 2015
Closed
@MorrisJobke
Copy link
Contributor

@DeepDiver1975 Broken tests can't be fixed by jenkins branches;) Let me have a look at them and fix them ;)

@MorrisJobke MorrisJobke changed the title [WIP] Moving mysql setup code over to Doctrine Moving mysql setup code over to Doctrine Jul 30, 2015
@DeepDiver1975
Copy link
Member Author

THX @MorrisJobke

@LukasReschke
Copy link
Member

Requires some more fine tuning for PHP 7. Let me hijack this one.

@LukasReschke LukasReschke self-assigned this Jul 30, 2015
@LukasReschke LukasReschke removed their assignment Jul 30, 2015
@scrutinizer-notifier
Copy link

A new inspection was created.

@LukasReschke
Copy link
Member

Modified so that the setup also checks against PDO instead of the removed deprecated function. Installation does now work on PHP 7 👍

@DeepDiver1975
Copy link
Member Author

Installation does now work on PHP 7 👍

great - thx - this was my next step ... thanks for jumping in

@ghost
Copy link

ghost commented Jul 30, 2015

🚀 Test PASSed.🚀
chuck

@MorrisJobke
Copy link
Contributor

👍

MorrisJobke added a commit that referenced this pull request Jul 30, 2015
@MorrisJobke
Merge pull request #17963 from owncloud/remove-derecated-mysql-functions
80810ae 
Moving mysql setup code over to Doctrine
@MorrisJobke MorrisJobke merged commit 80810ae into master Jul 30, 2015
@MorrisJobke MorrisJobke deleted the remove-derecated-mysql-functions branch July 30, 2015 13:21
@DeepDiver1975
Copy link
Member Author

THX

@MorrisJobke MorrisJobke mentioned this pull request Aug 18, 2015
Closed
@MorrisJobke MorrisJobke mentioned this pull request Nov 10, 2015
Closed
@slokhorst slokhorst mentioned this pull request Dec 6, 2015
Closed
MorrisJobke referenced this pull request Dec 8, 2015
@butonic
mysql ... initial hack
23b67bc
@lock lock bot locked as resolved and limited conversation to collaborators Aug 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
3 - To Review
Projects
None yet
Milestone
8.2
Development

Successfully merging this pull request may close these issues.

deprecated mysql_connect should be replaced with PDO
5 participants
@DeepDiver1975 @karlitschek @MorrisJobke @LukasReschke @scrutinizer-notifier