New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply new checkbox style to admin settings #19744
Conversation
cc @owncloud/designers @PVince81 |
Tested and works 👍 |
Code looks good 👍 |
Isn’t this also something which we should backport to 8.2 then? cc @karlitschek @cmonteroluque because atm in some places we have the new checkboxes, and in some we don’t, which is not very elegant. |
yes. backport please. honestly i'm surprised that this wasn't fixed a long time ago |
Yeah, I was also confused pulling the new code coming back from vacation. ;) But great work @Henni! :) |
the explanation is simple: the initial fix touched ALL the checkboxes that have a "label" tag. But since some apps didn't have them, their checkboxes were broken. So the initial fix was not acceptable due to app breakage and was reverted, and now checkbox styles need to be opt-in. So all checkboxes that used to work with the old approach would need to be adjusted directly, and some might have been missed during the second pass. |
@Henni can you rebase so we can merge and backport? :) |
5bc0806
to
bf722d9
Compare
@jancborchardt done |
Apply new checkbox style to admin settings
@Henni please send a backport Pull request against stable8.2 |
@nickvergessen I'm not completely sure how to do this, but I'll try. |
And then send a PR against stable8.2 |
Backport admin checkboxes #19744 to stable8.2
fixes #19724
cc @jancborchardt