Allow storage wrappers to through a forbidden exception with retry information for clients #20494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -235,6 +237,8 @@ public function move($sourcePath, $destinationPath) { | |||
| } | |||
| } catch (StorageNotAvailableException $e) { | |||
| throw new \Sabre\DAV\Exception\ServiceUnavailable($e->getMessage()); | |||
| } catch (ForbiddenException $ex) { | |||
| throw new Forbidden($ex->getMessage(), $ex->getRetry()); | |||
There was a problem hiding this comment.
Make this DAVForbiddenException everywhere to avoid confusion ?
There was a problem hiding this comment.
Not really sure it helps a lot. DAV could still be the app or sabre...
|
Code looks good otherwise 👍 |
| * @return int | ||
| */ | ||
| public function getHTTPCode() { | ||
| return 403; |
There was a problem hiding this comment.
Sounds like the perfect use case for HTTP 451: Unavailable For Legal Reasons 😄
There was a problem hiding this comment.
No need to overload - base already implements this as 403
There was a problem hiding this comment.
Right, I didn't extend in the beginning, so this was just a left over. will fix in a minute
|
👍 looks good |
|
I'm missing tests 👿 |
nickvergessen
force-pushed
the
storage-forbidden-exception
branch
from
4b2a8db
to
0ab8a4c
Compare
nickvergessen
force-pushed
the
storage-forbidden-exception
branch
from
0ab8a4c
to
e2cfcd9
Compare
|
@DeepDiver1975 added some tests to the dav stuff to test exception convertion and exception serialization |
DeepDiver1975
added a commit
that referenced
this pull request
Nov 18, 2015
Allow storage wrappers to through a forbidden exception with retry information for clients
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current response on webdav requests:
@DeepDiver1975 @icewind1991
Required for FW storage wrapper.
Currently reason === exception message, not sure if we want to keep it like that, but for now that should be fine so we can continue the actual work.