Cache: also check if the file id is already in the cache during upgrade #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should solve upgrade issues if only some of the configured storages were migrated previously
|
Very good to have this fixed 👍 |
|
Can you do just one query with the id to see if it is already in the filecache? |
|
Great ! btw its a ref to #2091 |
|
It works great for me with a external drive attached (Google) |
|
@MTGap right, fixed in the above commit |
|
👍 Waiting for build to finish. |
|
👍 looks good |
MTGap
pushed a commit
that referenced
this pull request
Mar 4, 2013
Cache: also check if the file id is already in the cache during upgrade
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should solve upgrade issues if only some of the configured storages were migrated previously.
The only way a a file id can already exists in the cache is when a previous upgrade attempt fails after at least one storage has been successfully upgraded
@MTGap @karlitschek @DeepDiver1975