Allow license.php for app repos aswell #22340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @DeepDiver1975, @LukasReschke and @MorrisJobke to be potential reviewers |
|
I see this which is caused by the git blame |
| $buildDir = getcwd(); | ||
| if ($gitRoot) { | ||
| chdir($gitRoot); | ||
| $file = substr($file, strlen($gitRoot) + 1); |
There was a problem hiding this comment.
removing the +1 fixes my issue
There was a problem hiding this comment.
ah, I ran apps/appname, you ran apps/appname/ will make it work for both.
|
Handling vendor code within the app also seems to have issues |
nickvergessen
force-pushed
the
allow-licensephp-for-app-repos-aswell
branch
from
f2ddbc1
to
100b357
Compare
|
tested with the mail app and works here now locally |
|
👍 |
1 similar comment
|
👍 |
DeepDiver1975
added a commit
that referenced
this pull request
Feb 17, 2016
…s-aswell Allow license.php for app repos aswell
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
cc @DeepDiver1975 @MorrisJobke @LukasReschke