New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix paths returned by \OC\Files\Storage\Shared hooks #23648
Conversation
By analyzing the blame information on this pull request, we identified @schiesbn, @icewind1991 and @MTGap to be potential reviewers |
Just to be sure, I suggest changing it to |
@icewind1991 @georgehrke what do you think ? |
I expect the mountpoint to already have a leading slash |
I would except the same, but it wasn't the case back in April and unless it's been fixed in all the Mountpoint classes in the mean time, it should still be a problem. |
Maybe this PR would fix things: #24564 |
Steps to reproduce on stable8.2:
My result on stable8.2:
Indeed there's a problem there. |
@icewind1991 said a "leading slash". But this PR is about a trailing slash in the mount point. I think this PR is acceptable. Will double check stable9 and master. |
Same issue on stable9. On master/9.1 the code has changed a lot, and it looks like there is no more "file_get_contents" or "file_put_contents" hooks any more for the shared storage ?! Something to investigate separately, @icewind1991 expect some new tickets soon. @oparoz I'll close your PR. Can you send PRs only to stable9 and stable8.2 ? |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #23620
All targets in hooks should look like this:
'target' => $this->getMountPoint() . '/' . $path
@rullzer @PVince81