Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional indexes and missing primary keys #2433

Merged
merged 3 commits into from
Mar 19, 2013
Merged

Conversation

tanghus
Copy link
Contributor

@tanghus tanghus commented Mar 19, 2013

Tested with MySQL, SQLite and PostgreSQL.
Refs #2142, obsoletes #2191
@Raydiation @karlitschek @DeepDiver1975 @roha4000 @PatrickHeller

Sorry for the messy history, I forgot to change branch.

@karlitschek
Copy link
Contributor

👍

@BernhardPosselt
Copy link
Contributor

Cool, db upgrade works for me :) 👍

BernhardPosselt added a commit that referenced this pull request Mar 19, 2013
Additional indexes and missing primary keys
@BernhardPosselt BernhardPosselt merged commit 5902ba5 into master Mar 19, 2013
@BernhardPosselt BernhardPosselt deleted the db_primary_keys branch March 19, 2013 09:43
@tanghus
Copy link
Contributor Author

tanghus commented Mar 19, 2013

@karlitschek @DeepDiver1975 @Raydiation Should I backport or do we want to test more thoroughly for regressions?

@karlitschek
Copy link
Contributor

We need at least tests from @DeepDiver1975 and @butonic for Oracle and MSSQL before backporting

@DeepDiver1975
Copy link
Member

Testing ....

@DeepDiver1975
Copy link
Member

Overall the migration of the database schema was successful on MSSQL.
One exception: no primary keys are generated - but because no primary key is available any table I suspect an unrelated issue with the MSSQL schema creation. I'll dig into this.

@tanghus
Copy link
Contributor Author

tanghus commented Mar 19, 2013

Thanks, that was sort the idea with the patch ;)

@lock lock bot locked as resolved and limited conversation to collaborators Aug 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants