Remove the password from the validateUserPass() method as well #24336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @LukasReschke, @MorrisJobke and @bartv2 to be potential reviewers |
|
Makes sense 👍 |
|
Ah yes, of course 👍 |
|
@nickvergessen conflicts ahead 😦 |
nickvergessen
force-pushed
the
issue-24328-remove-password-from-exception-trace-in-dav-auth
branch
from
36c3ea4
to
3397e27
Compare
|
Well @rullzer renamed the file, so git managed to fix itself. |
DeepDiver1975
deleted the
issue-24328-remove-password-from-exception-trace-in-dav-auth
branch
|
@karlitschek @cmonteroluque @nickvergessen What about the backport? still a thing? |
|
i think this this is a safe backport. please do. 👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #24328
@LukasReschke @ckruetze @MorrisJobke