Add files:scan warning when NFD or incompatible encoding found #24341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @nickvergessen, @LukasReschke, @icewind1991 and @Xenopathic to be potential reviewers |
|
You can use this bundle to test: https://s3.owncloud.com/owncloud/index.php/s/c8gosiF8GZZHYMT |
|
Tested and works 👍 |
|
👍 looks good |
|
Conflicts ? Pretty sure it's your fault @icewind1991 😉 Resolving... |
added 2 commits
April 29, 2016 16:18
This makes sure that even if a NFD file name exists, it is found by the storage and will be visible to higher layers. Even though the file will be discarded anyway there, it gives the scanner a chance to display a warning at least.
PVince81
force-pushed
the
scan-nfd-showwarning
branch
from
99bc095
to
4326d73
Compare
|
Rebased |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also comes with an additional fix for SMB and adds an option to
normalizePathsto optionally disable UTF-8 normalizing which will be needed further for #21365Please review @icewind1991 @nickvergessen @schiesbn @rullzer