Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont update search onResize #24682

Merged
merged 1 commit into from May 24, 2016
Merged

dont update search onResize #24682

merged 1 commit into from May 24, 2016

Conversation

fl4p
Copy link
Contributor

@fl4p fl4p commented May 17, 2016

Searchbox is broken at least on latest Android Chrome. this.updateSearch() sets the current file list instance and clears the box. This is unnecessary and makes the search box unsuable on some mobile devices where a keyboard fade-in triggers onResize, which would then clear and blur and finally hide the box.

this.updateSearch() sets the current file list instance and clears the box. This is unnecessary and makes the search box unsuable on some mobile devices where a keyboard fade-in causes a onResize trigger, which would then clear and blur the box.
@fl4p
Copy link
Contributor Author

fl4p commented May 17, 2016

This contribution is MIT licensed.

@ghost
Copy link

ghost commented May 17, 2016

@f4bsch

Thanks a lot for your contribution!
Contributions to the core repo require a signed contributors agreement http://owncloud.org/about/contributor-agreement/

Alternatively you can add a comment here where you state that this contribution is MIT licensed.

Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/

@nickvergessen
Copy link
Contributor

Indeed, I can reproduce this on my phone and can confirm that this here fixes it 👍

GJ and welcome to ownCloud

@PVince81
Copy link
Contributor

@butonic you're the one who added that line, can you confirm that it's ok to remove it ? Or did it have a specific important purpose ?

@PVince81
Copy link
Contributor

CC @georgehrke

@nickvergessen
Copy link
Contributor

I'd also vote to backport this, to be able to search on mobile in 9.0 again

@PVince81
Copy link
Contributor

Looks fine 👍

@PVince81
Copy link
Contributor

JS unit tests pass locally.

Also, I tested this commit cherry-picked against 9.0.2 and it worked fine too. (note that on master I couldn't get proper results due to #24803)

@f4bsch mind making another PR for stable9 ? (backport)

@PVince81
Copy link
Contributor

Needs backport down to 8.1: #17967 (comment)

CC @michaelstingl

@fl4p
Copy link
Contributor Author

fl4p commented May 25, 2016

backport
stable9 #24848
stable8.2 #24862
stable8.1 #24849

@michaelstingl
Copy link

@f4bsch Thanks for your help! Could you submit a stable8.2 too?

@georgehrke
Copy link
Contributor

stable8.2: #24862

@lock
Copy link

lock bot commented Aug 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants