New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dont update search onResize #24682
dont update search onResize #24682
Conversation
this.updateSearch() sets the current file list instance and clears the box. This is unnecessary and makes the search box unsuable on some mobile devices where a keyboard fade-in causes a onResize trigger, which would then clear and blur the box.
This contribution is MIT licensed. |
@f4bsch Thanks a lot for your contribution! Alternatively you can add a comment here where you state that this contribution is MIT licensed. Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/ |
Indeed, I can reproduce this on my phone and can confirm that this here fixes it 👍 GJ and welcome to ownCloud |
@butonic you're the one who added that line, can you confirm that it's ok to remove it ? Or did it have a specific important purpose ? |
CC @georgehrke |
I'd also vote to backport this, to be able to search on mobile in 9.0 again |
Looks fine 👍 |
JS unit tests pass locally. Also, I tested this commit cherry-picked against 9.0.2 and it worked fine too. (note that on master I couldn't get proper results due to #24803) @f4bsch mind making another PR for stable9 ? (backport) |
Needs backport down to 8.1: #17967 (comment) |
@f4bsch Thanks for your help! Could you submit a stable8.2 too? |
stable8.2: #24862 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Searchbox is broken at least on latest Android Chrome. this.updateSearch() sets the current file list instance and clears the box. This is unnecessary and makes the search box unsuable on some mobile devices where a keyboard fade-in triggers onResize, which would then clear and blur and finally hide the box.