Searchbox is broken at least on latest Android Chrome. this.updateSearch() sets the current file list instance and clears the box. This is unnecessary and makes the search box unsuable on some mobile devices where a keyboard fade-in triggers onResize, which would then clear and blur and finally hide the box.
dont update search onResize
this.updateSearch() sets the current file list instance and clears the box. This is unnecessary and makes the search box unsuable on some mobile devices where a keyboard fade-in causes a onResize trigger, which would then clear and blur the box.
This contribution is MIT licensed.
Thanks a lot for your contribution!
Contributions to the core repo require a signed contributors agreement http://owncloud.org/about/contributor-agreement/
Alternatively you can add a comment here where you state that this contribution is MIT licensed.
Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/
Indeed, I can reproduce this on my phone and can confirm that this here fixes it 👍
GJ and welcome to ownCloud
@butonic you're the one who added that line, can you confirm that it's ok to remove it ? Or did it have a specific important purpose ?
I'd also vote to backport this, to be able to search on mobile in 9.0 again
Looks fine 👍
JS unit tests pass locally.
Also, I tested this commit cherry-picked against 9.0.2 and it worked fine too. (note that on master I couldn't get proper results due to #24803)
@f4bsch mind making another PR for stable9 ? (backport)
Needs backport down to 8.1: #17967 (comment)
@f4bsch Thanks for your help! Could you submit a stable8.2 too?