dont update search onResize #24682

Merged
merged 1 commit into from May 24, 2016

Projects

None yet

7 participants

@f4bsch
Contributor
f4bsch commented May 17, 2016

Searchbox is broken at least on latest Android Chrome. this.updateSearch() sets the current file list instance and clears the box. This is unnecessary and makes the search box unsuable on some mobile devices where a keyboard fade-in triggers onResize, which would then clear and blur and finally hide the box.

@f4bsch f4bsch dont update search onResize
this.updateSearch() sets the current file list instance and clears the box. This is unnecessary and makes the search box unsuable on some mobile devices where a keyboard fade-in causes a onResize trigger, which would then clear and blur the box.
2a7d3dd
@f4bsch
Contributor
f4bsch commented May 17, 2016

This contribution is MIT licensed.

@owncloud-bot
Collaborator

@f4bsch

Thanks a lot for your contribution!
Contributions to the core repo require a signed contributors agreement http://owncloud.org/about/contributor-agreement/

Alternatively you can add a comment here where you state that this contribution is MIT licensed.

Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/

@nickvergessen
Contributor

Indeed, I can reproduce this on my phone and can confirm that this here fixes it 👍

GJ and welcome to ownCloud

@nickvergessen nickvergessen added this to the 9.1-current milestone May 18, 2016
@PVince81
Collaborator

@butonic you're the one who added that line, can you confirm that it's ok to remove it ? Or did it have a specific important purpose ?

@PVince81
Collaborator
@nickvergessen
Contributor

I'd also vote to backport this, to be able to search on mobile in 9.0 again

@PVince81
Collaborator

Looks fine 👍

@PVince81
Collaborator

JS unit tests pass locally.

Also, I tested this commit cherry-picked against 9.0.2 and it worked fine too. (note that on master I couldn't get proper results due to #24803)

@f4bsch mind making another PR for stable9 ? (backport)

@PVince81 PVince81 merged commit f8bbbba into owncloud:master May 24, 2016

2 of 3 checks passed

cla-bot-core Build #4142 failed in 8 min 33 sec
Details
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PVince81
Collaborator

Needs backport down to 8.1: #17967 (comment)

CC @michaelstingl

@f4bsch
Contributor
f4bsch commented May 25, 2016 edited

backport
stable9 #24848
stable8.2 #24862
stable8.1 #24849

@michaelstingl

@f4bsch Thanks for your help! Could you submit a stable8.2 too?

@georgehrke
Contributor

stable8.2: #24862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment