Fix OCS Share API path response #25003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $node = $share->getNode(); | ||
| $result['path'] = $this->rootFolder->getUserFolder($localUser)->getRelativePath($node->getPath()); | ||
| $userFolder = $this->rootFolder->getUserFolder($this->currentUser->getUID()); | ||
| $node = $userFolder->getById($share->getNodeId())[0]; |
There was a problem hiding this comment.
check for non empty result from getById ?
There was a problem hiding this comment.
Ah right... in case of messed up shares... yeah lets check that...
A share can only be requested by 3 'types' of people * owner * initiator * recipient So we have to get the path as the current user. Since that is the only path that has any meaning to the user.
rullzer
force-pushed
the
fix_ocs_path_response
branch
from
88b5756
to
72c5535
Compare
|
This basically obsoletes the 'target' in the OCS SHare API response. |
|
Tested, works 👍 @rullzer also observed on 9.0, please backport after review |
|
Need seconds reviewer @ChristophWurst @nickvergessen @DeepDiver1975 @owncloud/sharing |
|
👍 looks good |
|
@rullzer please backport to 9.0 |
|
Backport in #25067 |
This was referenced Jan 11, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24997
There are only 3 possible types of users that can request a share via the OCS Share API:
Else they won't find the share.
This makes sure we get the share for the current user. So that the path is always something meaningfull for that user.
CC: @nickvergessen @PVince81 @icewind1991 @scriptPilot