Fix GDrive upload file which name might match the one of a folder

[PVince81]

Whenever a file is uploaded to GDrive, there is a check for that file
with and without extension, due to Google Docs files having no
extension. This logic now only kicks in whenever the detected
extensionless file is really a Google Doc file, not a folder.

This makes it possible again to upload a file "test.txt" in a folder
that also has a folder called "test"

Fixes #24631

[PVince81]

Please review @icewind1991 @Xenopathic @rullzer

I'll rerun the GDrive tests locally and post the result.

[PVince81]

Oh wow, that's cool:

Runtime:        PHP 5.5.14 with Xdebug 2.3.3
Configuration:  /srv/www/htdocs/owncloud/tests/phpunit-autotest.xml
Warning:        Deprecated configuration setting "strict" used

.............................................F..............F..F. 65 / 81 ( 80%)
................

Time: 10.42 minutes, Memory: 53.50Mb

There were 3 failures:

1) OCA\Files_External\Tests\Storage\GoogleTest::testStat
Failed asserting that false is true.

/srv/www/htdocs/owncloud/tests/lib/Files/Storage/Storage.php:288

2) OCA\Files_External\Tests\Storage\GoogleTest::testRenameOverWriteDirectory
target/test1.txt has not been overwritten
Failed asserting that false matches expected 'foo'.

/srv/www/htdocs/owncloud/tests/lib/Files/Storage/Storage.php:489

3) OCA\Files_External\Tests\Storage\GoogleTest::testCopyOverWriteDirectory
Failed asserting that true is false.

/srv/www/htdocs/owncloud/tests/lib/Files/Storage/Storage.php:540

FAILURES!
Tests: 81, Assertions: 419, Failures: 3.

less failures than master a while ago: #22481

[icewind1991]

👍 looks good

[guruz]

👍

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.