Add all properties when creating a subscription #25318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1079,22 +1079,27 @@ function createSubscription($principalUri, $uri, array $properties) { | |||
| 'lastmodified' => time(), | |||
| ]; | |||
|
|
|||
| foreach($this->subscriptionPropertyMap as $xmlName=>$dbName) { | |||
| if (isset($properties[$xmlName])) { | |||
| $propertiesBoolean = array('striptodos', 'stripalarms', 'stripattachments'); | |||
There was a problem hiding this comment.
please use short array declaration []
There was a problem hiding this comment.
Fixed and squashed commits.
|
@georgehrke please test again - thx |
tcitworld
force-pushed
the
add-all-properties-create-subscription
branch
from
ab562ad
to
126f256
Compare
|
looks good to me 👍 |
|
👍 |
DeepDiver1975
pushed a commit
that referenced
this pull request
Jul 1, 2016
DeepDiver1975
pushed a commit
that referenced
this pull request
Jul 8, 2016
* Revert "Merge pull request #25240 from owncloud/remove-svg" This reverts commit 8b8d2b6, reversing changes made to a35747b. * Revert "Merge pull request #25253 from owncloud/users-fixotherquotadropdown" This reverts commit a35747b, reversing changes made to a573b68. * Revert "Merge pull request #25314 from owncloud/files_external-backends-config" This reverts commit a573b68, reversing changes made to 8147eef. * Revert "Add all properties while creating a subscription (#25318)" This reverts commit aaf4c30. * Revert "Merge pull request #25276 from owncloud/delete-own-session-token" This reverts commit e42ce62, reversing changes made to aaf4c30. * Revert "Merge pull request #25262 from owncloud/fed-sharing-error" This reverts commit 027715f, reversing changes made to e42ce62.
DeepDiver1975
pushed a commit
that referenced
this pull request
Jul 21, 2016
DeepDiver1975
added a commit
that referenced
this pull request
Jul 21, 2016
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally at #25231
Fix #24469