New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.2] Web app manifest #25438

Merged
merged 1 commit into from Sep 20, 2016

Conversation

Projects
None yet
6 participants
@Rudloff
Contributor

Rudloff commented Jul 11, 2016

Hello,

I added a web app manifest.
It allows users to add the app to the Android homescreen (see https://developer.chrome.com/multidevice/android/installtohomescreen).

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jul 11, 2016

@Rudloff, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke, @jancborchardt and @Henni to be potential reviewers

@Rudloff, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke, @jancborchardt and @Henni to be potential reviewers

@owncloud-bot

This comment has been minimized.

Show comment
Hide comment
@owncloud-bot

owncloud-bot Jul 11, 2016

Contributor

@Rudloff

Thanks a lot for your contribution!
Contributions to the core repo require a signed contributors agreement http://owncloud.org/about/contributor-agreement/

Alternatively you can add a comment here where you state that this contribution is MIT licensed.

Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/

Contributor

owncloud-bot commented Jul 11, 2016

@Rudloff

Thanks a lot for your contribution!
Contributions to the core repo require a signed contributors agreement http://owncloud.org/about/contributor-agreement/

Alternatively you can add a comment here where you state that this contribution is MIT licensed.

Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/

@Rudloff

This comment has been minimized.

Show comment
Hide comment
@Rudloff

Rudloff Jul 11, 2016

Contributor

I didn't sign the contributor agreement but this contribution is MIT licensed.

Contributor

Rudloff commented Jul 11, 2016

I didn't sign the contributor agreement but this contribution is MIT licensed.

@DeepDiver1975 DeepDiver1975 added this to the 9.2 milestone Jul 11, 2016

@PVince81

This comment has been minimized.

Show comment
Hide comment
@davivel

This comment has been minimized.

Show comment
Hide comment
@davivel

davivel Aug 1, 2016

Member

looking

Member

davivel commented Aug 1, 2016

looking

@davivel

This comment has been minimized.

Show comment
Hide comment
@davivel

davivel Aug 1, 2016

Member

This is for Chrome for Android, not for the Android app - sorry for the confusion.

Member

davivel commented Aug 1, 2016

This is for Chrome for Android, not for the Android app - sorry for the confusion.

@DeepDiver1975

This comment has been minimized.

Show comment
Hide comment
@DeepDiver1975

DeepDiver1975 Sep 20, 2016

Member

tested - works 👍

Member

DeepDiver1975 commented Sep 20, 2016

tested - works 👍

@DeepDiver1975

This comment has been minimized.

Show comment
Hide comment
@DeepDiver1975

DeepDiver1975 Sep 20, 2016

Member

@Rudloff thanks a lot for your contribution!

Member

DeepDiver1975 commented Sep 20, 2016

@Rudloff thanks a lot for your contribution!

@DeepDiver1975 DeepDiver1975 merged commit 8385fe1 into owncloud:master Sep 20, 2016

2 of 7 checks passed

cla-bot-core Build #5243 failed in 14 sec
Details
core-ci-linux-php7.1/database=sqlite,label=SLAVE continuous-integration/php-7.1
Details
Jenkins job PR-25438 This commit cannot be built
Details
Jenkins This pull request is scheduled to be built
Details
licence/cla Contributor License Agreement is not signed yet.
Details
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Rudloff Rudloff deleted the Rudloff:feature/manifest branch Sep 20, 2016

@DeepDiver1975 DeepDiver1975 changed the title from Web app manifest to [9.2] Web app manifest Sep 20, 2016

@DeepDiver1975 DeepDiver1975 referenced this pull request Sep 21, 2016

Merged

Adjust csp tests to respect manifest-src self #26165

3 of 9 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment