Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.2] Web app manifest #25438

Merged
merged 1 commit into from Sep 20, 2016
Merged

Conversation

Rudloff
Copy link
Contributor

@Rudloff Rudloff commented Jul 11, 2016

Hello,

I added a web app manifest.
It allows users to add the app to the Android homescreen (see https://developer.chrome.com/multidevice/android/installtohomescreen).

@mention-bot
Copy link

@Rudloff, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke, @jancborchardt and @Henni to be potential reviewers

@ghost
Copy link

ghost commented Jul 11, 2016

@Rudloff

Thanks a lot for your contribution!
Contributions to the core repo require a signed contributors agreement http://owncloud.org/about/contributor-agreement/

Alternatively you can add a comment here where you state that this contribution is MIT licensed.

Some more details about out pull request workflow can be found here: http://owncloud.org/code-reviews-on-github/

@Rudloff
Copy link
Contributor Author

Rudloff commented Jul 11, 2016

I didn't sign the contributor agreement but this contribution is MIT licensed.

@DeepDiver1975 DeepDiver1975 added this to the 9.2 milestone Jul 11, 2016
@PVince81
Copy link
Contributor

@owncloud/designers @davivel

@davivel
Copy link

davivel commented Aug 1, 2016

looking

@davivel
Copy link

davivel commented Aug 1, 2016

This is for Chrome for Android, not for the Android app - sorry for the confusion.

@DeepDiver1975
Copy link
Member

tested - works 👍

@DeepDiver1975
Copy link
Member

@Rudloff thanks a lot for your contribution!

@DeepDiver1975 DeepDiver1975 merged commit 8385fe1 into owncloud:master Sep 20, 2016
@Rudloff Rudloff deleted the feature/manifest branch September 20, 2016 15:26
@DeepDiver1975 DeepDiver1975 changed the title Web app manifest [9.2] Web app manifest Sep 20, 2016
@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants