Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable9] Escape special characters (#25429) #26409

Merged
merged 1 commit into from Oct 19, 2016

Conversation

DeepDiver1975
Copy link
Member

backport of (#25429)

* Escape LIKE parameter

* Escape LIKE parameter

* Escape LIKE parameter

* Escape LIKE parameter

* Escape LIKE parameter

* Use correct method in the AbstractMapping class

* Change the getNamesBySearch method so that input can be properly escaped while still supporting matches

* Don't escape hardcoded wildcard
@DeepDiver1975 DeepDiver1975 added this to the 9.0.6 milestone Oct 19, 2016
@mention-bot
Copy link

@DeepDiver1975, thanks for your PR! By analyzing the history of the files in this pull request, we identified @blizzz, @nickvergessen and @PVince81 to be potential reviewers.

@davitol
Copy link
Contributor

davitol commented Oct 19, 2016

- ❌ TEST: custom webdav prop can be set with PROPPATCH and retrieved with PROPFIND

After applying the patch:
curl -X PROPPATCH -H "Content-Type: text/xml" --data-binary "@proppatch.txt" http://admin:Password@myserver/remote.php/webdav/aaa.txt | xmllint --format -

  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   472  100   235  100   237    865    872 --:--:-- --:--:-- --:--:--   871
<?xml version="1.0" encoding="utf-8"?>
<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
  <s:exception>Sabre\DAV\Exception\NotFound</s:exception>
  <s:message>File with name aaa.txt could not be located</s:message>
</d:error>

Not sure if i'm missing some step @DeepDiver1975
Tested again and it seems to work fine, so 👍

@PVince81
Copy link
Contributor

I tested LDAP with groups and it seems to work fine 👍

@PVince81 PVince81 merged commit ed468d5 into stable9 Oct 19, 2016
@PVince81 PVince81 deleted the stable9-36d6f3ba8b7b7db8f4d8b2a70504fd184a30cc50 branch October 19, 2016 13:47
@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants