Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix malformed attribute in files app #26477

Merged
merged 1 commit into from
Oct 25, 2016
Merged

Conversation

PVince81
Copy link
Contributor

Description

Fix malformed attribute in files template.
It doesn't seem to affect functionality however.

Related Issue

Discovered while testing in IE11 here, no issue raised.

How Has This Been Tested?

Test in IE11, check console.
Before this fix: warning about malformed attribute.
After this fix: no more warning.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 @PhilippSchaffrath @felixheidecke

@mention-bot
Copy link

@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @DeepDiver1975 and @schiessle to be potential reviewers.

@DeepDiver1975
Copy link
Member

👍

@PVince81 PVince81 merged commit 0d8f35b into master Oct 25, 2016
@PVince81 PVince81 deleted the fix-malformed-attribute branch October 25, 2016 13:20
@PVince81
Copy link
Contributor Author

stable9.1: #26480

@phisch
Copy link
Contributor

phisch commented Oct 25, 2016

👍 lucky that browsers are so forgiving :)
edit: i was too late

@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants