Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons to settings sections in admin/personal #26759

Closed
wants to merge 48 commits into from

Conversation

tomneedham
Copy link
Member

Description

Adds icons to the settings section on the new settings page:

screen shot 2016-12-02 at 13 48 59

Depends on #26449 .

Motivation and Context

  • Looks pretty

How Has This Been Tested?

  • Unit test
  • Manual visual check

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • x] I have added tests to cover my changes.
  • All new and existing tests passed.

@felixheidecke

Tom Needham and others added 30 commits November 10, 2016 11:43
- adjust some styling
- remote filesexternal section - now provided by the app itself
- code cleanup
@mention-bot
Copy link

@tomneedham, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @Kondou-ger, @PVince81 and @Xenopathic to be potential reviewers.

@DeepDiver1975 DeepDiver1975 changed the base branch from master to settings-panels December 5, 2016 13:28
@DeepDiver1975
Copy link
Member

This is pretty cool - THX.

Let's introduce this once we have #26449 done

@tomneedham
Copy link
Member Author

Closing in favour of #27202

@tomneedham tomneedham closed this Feb 21, 2017
@tomneedham tomneedham deleted the settings-icons branch February 21, 2017 13:53
@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants