Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable9.1] cache getStorageById #27349

Merged
merged 10 commits into from Mar 10, 2017
Merged

Conversation

butonic
Copy link
Member

@butonic butonic commented Mar 9, 2017

backport of #27312 to stable9.1

@mention-bot
Copy link

@butonic, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Xenopathic, @PVince81 and @icewind1991 to be potential reviewers.

@butonic butonic added this to the 9.1.5 milestone Mar 9, 2017
@butonic butonic requested review from PVince81 and phisch March 9, 2017 20:43
@PVince81
Copy link
Contributor

You can't use this with PHP 5.4:

Parse error: ./tests/lib/Files/ViewTest.php:129

    127| 	 */

    128| 	protected function resetStorage() {

  > 129| 		$storage = new \ReflectionClass(Storage::class);

    130| 		$property = $storage->getProperty('localCache');

    131| 		$property->setAccessible(true);

Unexpected 'class' (T_CLASS), expecting identifier (T_STRING) or variable (T_VARIABLE) or '{' or '$'

Need to change Storage::class to a string with namespace...

@PVince81
Copy link
Contributor

Did some tests, works 👍

@PVince81 PVince81 merged commit 6a6d81e into stable9.1 Mar 10, 2017
@PVince81 PVince81 deleted the stable9.1-cache-getStorageById branch March 10, 2017 13:47
@PVince81 PVince81 mentioned this pull request Mar 10, 2017
9 tasks
@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants