Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload file list when leaving hidden state #27703

Merged
merged 1 commit into from Apr 20, 2017
Merged

Conversation

PVince81
Copy link
Contributor

Description

Whenever a file list is already initialized and was hidden when
switching to another file list in the navigation bar, if the user comes
back to this list it gets redisplayed. At this point the list needs to
be refreshed to be able to reflect any potential file changes done from
the other lists.

Related Issue

Fixes #27697

Motivation and Context

See description and ticket

How Has This Been Tested?

See ticket steps

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Please review @jvillafanez @noveens

Whenever a file list is already initialized and was hidden when
switching to another file list in the navigation bar, if the user comes
back to this list it gets redisplayed. At this point the list needs to
be refreshed to be able to reflect any potential file changes done from
the other lists.
@jvillafanez
Copy link
Member

I don't expect any dangerous thing happening if we reload twice or more other than more network traffic, so I think it's fine 👍

@PVince81
Copy link
Contributor Author

I checked the network traffic and it only re-requests the contents once.

The reason is that even though the urlChanged event is called after show as before, the current folder did not change so it doesn't reload there. That's why I had to add an extra reload inside show.

@PVince81 PVince81 merged commit 631af7a into master Apr 20, 2017
@PVince81 PVince81 deleted the filelist-refreshonswitch branch April 20, 2017 14:49
@PVince81
Copy link
Contributor Author

Apparently now the file list is always loaded twice... once for the "show" event and once for the "urlChanged"... 😞

@PVince81
Copy link
Contributor Author

raised as regression here #27890

@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File lists do not properly reload when switching
2 participants