Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Makefile to generate version.php, refactor #27945

Closed
wants to merge 1 commit into from

Conversation

PVince81
Copy link
Contributor

Description

Makefile now adds OC_Edition in version.php.
Refactored Makefile with functions used by both the regular and QA
build, for cleaning up unwanted files and updating version.php.

Related Issue

None

Motivation and Context

Remove the need to touch version.php in the internal release script.
Reuse some logic.

How Has This Been Tested?

Run make clean && make dist and check generated version.php. Check that test folders and git folders were removed as well.
Run make clean && make dist-qa and check generated version.php. Check that test folders are still there but ".git*" folders are gone.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 let's try this out after 10.0.1 is out.

@PVince81 PVince81 added this to the 10.0.2 milestone May 19, 2017
@PVince81
Copy link
Contributor Author

Hint on how to change the edition and channel:
make dist RELEASE_CHANNEL=testing RELEASE_EDITION=enterprise

@PVince81 PVince81 modified the milestones: 10.0.2, 10.0.3 May 26, 2017
@PVince81 PVince81 modified the milestones: 10.1, 10.0.3 Jun 21, 2017
@PVince81
Copy link
Contributor Author

PVince81 commented Jul 5, 2017

we can revive this, please review

Makefile now adds OC_Edition in version.php.
Refactored Makefile with functions used by both the regular and QA
build, for cleaning up unwanted files and updating version.php.
@PVince81
Copy link
Contributor Author

Rebased.

@codecov
Copy link

codecov bot commented Dec 18, 2017

Codecov Report

Merging #27945 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #27945   +/-   ##
=========================================
  Coverage     60.56%   60.56%           
  Complexity    18395    18395           
=========================================
  Files          1091     1091           
  Lines         60980    60980           
=========================================
  Hits          36935    36935           
  Misses        24045    24045

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 554f606...1d7ee6f. Read the comment docs.

@felixboehm felixboehm modified the milestones: development, planned Apr 10, 2018
@PVince81
Copy link
Contributor Author

abandoning this, might not even be relevant for the new build scripts once they arrive

if needed this can be reopened

@PVince81 PVince81 closed this Apr 25, 2018
@PVince81 PVince81 deleted the makefile-add-edition branch April 25, 2018 10:02
@PVince81 PVince81 modified the milestones: development, QA Jun 13, 2018
@patrickjahns
Copy link
Contributor

shall we resurrect this?

@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants