New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust Makefile to generate version.php, refactor #27945
Conversation
Hint on how to change the edition and channel: |
we can revive this, please review |
Makefile now adds OC_Edition in version.php. Refactored Makefile with functions used by both the regular and QA build, for cleaning up unwanted files and updating version.php.
ab58535
to
1d7ee6f
Compare
Rebased. |
Codecov Report
@@ Coverage Diff @@
## master #27945 +/- ##
=========================================
Coverage 60.56% 60.56%
Complexity 18395 18395
=========================================
Files 1091 1091
Lines 60980 60980
=========================================
Hits 36935 36935
Misses 24045 24045 Continue to review full report at Codecov.
|
abandoning this, might not even be relevant for the new build scripts once they arrive if needed this can be reopened |
shall we resurrect this? |
Description
Makefile now adds OC_Edition in version.php.
Refactored Makefile with functions used by both the regular and QA
build, for cleaning up unwanted files and updating version.php.
Related Issue
None
Motivation and Context
Remove the need to touch version.php in the internal release script.
Reuse some logic.
How Has This Been Tested?
Run
make clean && make dist
and check generated version.php. Check that test folders and git folders were removed as well.Run
make clean && make dist-qa
and check generated version.php. Check that test folders are still there but ".git*" folders are gone.Screenshots (if appropriate):
Types of changes
Checklist:
@DeepDiver1975 let's try this out after 10.0.1 is out.