Only VEVENT for birthday calendar and default order to 1

[tomneedham]

Description

New calendars are given a default order of 1, to always be after the default birthday calendar.

The system birthday calendar is created with VEVENT only, not VTODO as this is not possible.

Motivation and Context

Causes issues when the birthday calendar is used for accepting events or if TODOs are created in that calendar.

How Has This Been Tested?

• New install and observing the created calendars
  before:
  
  after:
  

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[tomneedham]

@DeepDiver1975 I can't find the code path for accepting an event from another user and where it is inserted into your calendar? Wanted to check where the logic is for choosing the calendar to insert it into.

[tomneedham]

@DeepDiver1975 hmm so I see there is already a migration to fix this - https://github.com/owncloud/core/pull/25636/files but annoyingly the fix didn't work. How often is that repair step called - as we still have corrupt birthday calendars

[DeepDiver1975]

fixes #26746 ❓

[DeepDiver1975]

@DeepDiver1975 I can't find the code path for accepting an event from another user and where it is inserted into your calendar? Wanted to check where the logic is for choosing the calendar to insert it into.

It is within the sabre dav libs:

this propfind handles the calendar selection - https://github.com/fruux/sabre-dav/blob/master/lib/CalDAV/Schedule/Plugin.php#L240
this is where the local delivery happens - https://github.com/fruux/sabre-dav/blob/master/lib/CalDAV/Schedule/Plugin.php#L444

[DeepDiver1975]

@DeepDiver1975 hmm so I see there is already a migration to fix this - https://github.com/owncloud/core/pull/25636/files but annoyingly the fix didn't work. How often is that repair step called - as we still have corrupt birthday calendars

best would be to add a migration from my pov

[tomneedham]

fixes #26746 ❓

yes should do - since I just push the birthday to the bottom of the users list

[DeepDiver1975]

lets keep the logging in here

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.