[stable9.1] Fix cross storage move info #28238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to properly resolve the given path to a source path in `getMoveInfo`. This was missing when adding this new method.
12 tasks
|
The CacheWrapper will properly forward the call to the wrapped cache.
|
Retested:
@jvillafanez please review, beware of the extra commit for the #27172 backport. Again, this is only the PR that prevents the issue. I'll also want to backport the other PR that makes files scan fix the fallout. |
|
Changes make sense 👍 Any reason why #27172 wasn't backported before? |
|
@jvillafanez I think it's because it only fixed a theoretical issue, a unit test that only existed on that branch. Now we can see why that backport is actually needed. |
ghost
mentioned this pull request
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #28022 to stable9.1.
However this does not work. The integration test will fail.I also tested this manually and it still produces broken entries.So the fix itself might need to be slightly different for stable9.1.Edit: Works now, required an additional backport