Fix encoding mismatch in JS #28749
Merged
Fix encoding mismatch in JS #28749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Encode with encodeURIComponent again. Note that "@" gets encoded to "%40" but when Sabre DAV returns a PROPFIND response, the "@" in the URL is not encoded. To make sure that the href root is properly match, we now compare each section individually in their decoded form.
This was referenced Aug 21, 2017
individual-it
approved these changes
Aug 21, 2017
There was a problem hiding this comment.
with the fix I could not reproduce the bug any-more.
added some UI tests, lets see what travis says.
@phil-davis please review my test cases
phil-davis
approved these changes
Aug 21, 2017
Life on Mars |
The client takes care of encoding them when doing the Webdav requests
DeepDiver1975
approved these changes
Aug 22, 2017
|
Backport of newdav + this PR here: #28769 |
|
Tested and WFM 👍 |
9 tasks
|
one of the recent changes related to encoding have added new tests that somehow very indirectly trigger some annoying logs on the console "ERROR: undefined". I've fixed this in this follow up PR: #28772 (JS tests only) |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Encode with encodeURIComponent again.
Note that "@" gets encoded to "%40" but when Sabre DAV returns a
PROPFIND response, the "@" in the URL is not encoded. To make sure that
the href root is properly match, we now compare each section
individually in their decoded form.
Related Issue
Fixes #28748
Motivation and Context
How Has This Been Tested?
JS unit tests.
Create a folder "test@?#" in the web UI and navigate into it.
Create a user "test@test" with a subfolder, navigate into it.
Screenshots (if appropriate):
Types of changes
Checklist: