Check the return value of getUserSession before using it

[sharidas]

Checking if the value returned by getUserSession
and getUser is null or not before using it.

Signed-off-by: Sujith H sharidasan@owncloud.com

Description

There were situations where userSession was directly calling getUser which returned null and the return value was never checked. Another case was getUserSession was returning null. Hence getUser was called on null. This caused breaking the code flow under certain conditions. This change is to fix the assumptions made.

Related Issue

#30335
#30416

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[PVince81]

Please add unit tests there

[codecov]

Codecov Report

Merging #30418 into master will increase coverage by <.01%.
The diff coverage is 91.66%.

@@             Coverage Diff              @@
##             master   #30418      +/-   ##
============================================
+ Coverage     60.87%   60.88%   +<.01%     
- Complexity    18568    18572       +4     
============================================
  Files          1093     1093              
  Lines         61325    61329       +4     
============================================
+ Hits          37333    37339       +6     
+ Misses        23992    23990       -2

Impacted Files	Coverage Δ	Complexity Δ
lib/private/User/User.php	83.72% <100%> (+0.19%)	67 <0> (+3)	⬆️
lib/private/Log.php	79.51% <83.33%> (+2.97%)	37 <0> (+1)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a6ec7d...9a1b527. Read the comment docs.

[sharidas]

Updated with unit tests.

[PVince81]

Thanks. Is there also a positive test for when log conditions are set and a user is present ?

[sharidas]

Thanks. Is there also a positive test for when log conditions are set and a user is present ?

Yes the positive tests are already there.

[PVince81]

👍

[phil-davis]

I guess this needs to be backported?

[sharidas]

Creating backport PR.

[sharidas]

Backport PR: #30432

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.