Email autocomplete for link shares

[PVince81]

Description

Bring back email autocomplete for link shares.

Related Issue

#30670

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[PVince81]

I managed to recover this code from before the squash of #30645.

It doesn't seem to work so maybe it wasn't the latest version. Or there were further changes.

@felixheidecke @DeepDiver1975

[PVince81]

plug OC.getCapabilities().files_sharing.search_min_length here.

[codecov]

Codecov Report

Merging #30987 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master   #30987      +/-   ##
============================================
- Coverage     62.31%   62.29%   -0.02%     
  Complexity    18208    18208              
============================================
  Files          1142     1142              
  Lines         68190    68210      +20     
  Branches       1232     1234       +2     
============================================
  Hits          42494    42494              
- Misses        25335    25355      +20     
  Partials        361      361

Flag	Coverage Δ	Complexity Δ
#javascript	51.97% <0%> (-0.08%)	0 <0> (ø)
#phpunit	63.47% <0%> (-0.02%)	18208 <0> (ø)

Impacted Files	Coverage Δ	Complexity Δ
apps/dav/lib/CardDAV/AddressBookImpl.php	72.61% <0%> (-1.78%)	26 <0> (ø)
core/js/sharedialogmailview.js	57.44% <0%> (-6.84%)	0 <0> (ø)
core/ajax/share.php	0% <0%> (ø)	0 <0> (ø)	⬇️
lib/public/Util/UserSearch.php	100% <0%> (ø)	4% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e2b8aa...a6aebb5. Read the comment docs.

[DeepDiver1975]

What is this? @PVince81 @tomneedham

There was 1 failure:

1) Test\Repair\RepairOrphanedSubshareTest::testLargeSharesWithOrphans
Failed asserting that 82 matches expected 81.

/drone/src/tests/lib/Repair/RepairOrphanedSubshareTest.php:288

--

[PVince81]

this was merged recently, it's from @sharidas' #30186, maybe a random test side effect of some sorts :-S

let's see if reproducible

[PVince81]

• add search_min_length on backend as well

[PVince81]

Tested:

• TEST: local users not returned

• TEST: federated users not returned

• TEST: contacts from contacts app returned

• TEST: min-length respected on client side

• TEST: min-length respected on backend

[PVince81]

👍 for the changes from @felixheidecke @DeepDiver1975 (I can't approve my own PR)

CI will likely fail randomly due to issues, waiting for #30992

[PVince81]

@ownclouders rebase

[ownclouders]

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

[ownclouders]

Automated rebase with GitMate.io was successful! 🎉

[PVince81]

stable10: #30998

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.