Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Skip two factor challenge in account module middleware #32329

Merged

Conversation

DeepDiver1975
Copy link
Member

Fixes issue with infinite redirect when trying to access the challenge
page.

port of #32058

Fixes issue with infinite redirect when trying to access the challenge
page.
@codecov
Copy link

codecov bot commented Aug 14, 2018

Codecov Report

Merging #32329 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #32329      +/-   ##
============================================
+ Coverage     64.01%   64.01%   +<.01%     
- Complexity    18560    18561       +1     
============================================
  Files          1171     1171              
  Lines         69841    69843       +2     
  Branches       1267     1267              
============================================
+ Hits          44709    44711       +2     
  Misses        24762    24762              
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.84% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.29% <100%> (ø) 18561 <0> (+1) ⬆️
Impacted Files Coverage Δ Complexity Δ
core/Middleware/AccountModuleMiddleware.php 100% <100%> (ø) 11 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc75987...ce7bd1d. Read the comment docs.

@DeepDiver1975 DeepDiver1975 merged commit 6b535c6 into master Aug 16, 2018
@DeepDiver1975 DeepDiver1975 deleted the master-fb10062de7ee385251161677ea3021ebbaecc3c5 branch August 16, 2018 12:32
@lock lock bot locked as resolved and limited conversation to collaborators Aug 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants