phpcs acceptance test style #32877
Merged
phpcs acceptance test style #32877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #32877 +/- ##
=========================================
Coverage 64.12% 64.12%
Complexity 18684 18684
=========================================
Files 1177 1177
Lines 70309 70309
Branches 1270 1270
=========================================
Hits 45089 45089
Misses 24850 24850
Partials 370 370
Continue to review full report at Codecov.
|
paurakhsharma
approved these changes
Sep 27, 2018
|
Backport |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the commit from PR #32785
It fixes all the reported code style of the acceptance tests.
We may as well have these fixes in master and stable10 right now, so that as we continue to code wwe start with "clean" code.