Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Set versions to 10.1 for semver #33242

Closed
wants to merge 1 commit into from

Conversation

PVince81
Copy link
Contributor

Description

Simply sets the versions to 10.1 and adjust max-version for all core apps.
⚠️ don't merge yet, this is to check CI. Will be merged when all other offical apps are ready ⚠️

Related Issue

https://github.com/owncloud/enterprise/issues/2532

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Starting with 10.1 we're going to do semver.
@codecov
Copy link

codecov bot commented Oct 20, 2018

Codecov Report

Merging #33242 into stable10 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #33242   +/-   ##
===========================================
  Coverage       62.91%   62.91%           
  Complexity      18867    18867           
===========================================
  Files            1237     1237           
  Lines           73961    73961           
  Branches         1282     1282           
===========================================
  Hits            46529    46529           
  Misses          27052    27052           
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.16% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.96% <100%> (ø) 18867 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
version.php 100% <100%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff59580...7cc35ad. Read the comment docs.

@PVince81
Copy link
Contributor Author

it actually needs to be max-version=10.

will resubmit to avoid confusion

@PVince81 PVince81 closed this Nov 13, 2018
@PVince81 PVince81 deleted the stable10-semver-10.1 branch November 13, 2018 10:17
@PVince81
Copy link
Contributor Author

new PR here for max-version=10: #33496

@lock lock bot locked as resolved and limited conversation to collaborators Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant