Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/multibucket share copy #33456

Merged
merged 4 commits into from Nov 9, 2018
Merged

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Nov 7, 2018

Description

In a multibucket objectstore scenario the move operation needs to respect that source and target live on different buckets -> objectst have to be moved physically ...

How Has This Been Tested?

  • manually
  • automation in progress

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov
Copy link

codecov bot commented Nov 7, 2018

Codecov Report

Merging #33456 into master will decrease coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #33456      +/-   ##
============================================
- Coverage     64.07%   64.07%   -0.01%     
- Complexity    18313    18315       +2     
============================================
  Files          1192     1192              
  Lines         69162    69167       +5     
  Branches       1277     1277              
============================================
+ Hits          44319    44322       +3     
- Misses        24471    24473       +2     
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 52.91% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.37% <66.66%> (-0.01%) 18315 <0> (+2)
Impacted Files Coverage Δ Complexity Δ
...b/private/Files/ObjectStore/ObjectStoreStorage.php 85.56% <100%> (+0.1%) 101 <0> (+1) ⬆️
...ib/private/Files/Mount/ObjectHomeMountProvider.php 90.47% <50%> (-4.4%) 15 <0> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 309dbaa...bc8daa9. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far

@PVince81
Copy link
Contributor

PVince81 commented Nov 8, 2018

conflicts ??

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DeepDiver1975 DeepDiver1975 merged commit cca67d6 into master Nov 9, 2018
@DeepDiver1975 DeepDiver1975 deleted the bugfix/multibucket-share-copy branch November 9, 2018 15:55
DeepDiver1975 added a commit that referenced this pull request Nov 9, 2018
DeepDiver1975 added a commit that referenced this pull request Nov 9, 2018
Merge pull request #33456 from owncloud/bugfix/multibucket-share-copy
@lock lock bot locked as resolved and limited conversation to collaborators Nov 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants