[stable10] Backport of Use loadFromFile instead of loadFromFileHandle #34356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use loadFromFile instead of loadFromFileHandle
while generating the thumbnail.
Signed-off-by: Sujith H sharidasan@owncloud.com
Description
When
loadFromFileHandle
is used for generating thumbnail of images, the problem found is that it doesn't fix the orientation of images with exif. WhileloadFromFile
handles this. It usesexif_imagetype
before checking the mimetype of the image file. There is a word of caution noted in the https://github.com/owncloud/core/blob/master/lib/private/legacy/image.php#L496 ( reference: http://php.net/manual/en/function.exif-imagetype.php#79283 ). With the changeset the orientation issue while generating preview is resolved.Related Issue
Motivation and Context
This changeset fixes the orientation issue of images while generating preview.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: