Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test user-based 'Automatically accept new incoming local user shares' setting #34711

Merged
merged 1 commit into from Mar 7, 2019

Conversation

individual-it
Copy link
Member

Description

first set of tests that check if the user-based setting for auto-accepting local shares works

Related Issue

part of tests for https://github.com/owncloud/enterprise/issues/3128

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@phil-davis
Copy link
Contributor

drone https://drone.owncloud.com/owncloud/core/15827/446

Error response from daemon: create 0_4489694667017315378_default: error while creating volume path '/var/lib/docker/volumes/0_4489694667017315378_default/_data': mkdir /var/lib/docker/volumes/0_4489694667017315378_default: read-only file system

drone will need restarting when the general drone problem has been resolved.

@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #34711 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34711   +/-   ##
=========================================
  Coverage     65.28%   65.28%           
  Complexity    18481    18481           
=========================================
  Files          1210     1210           
  Lines         69984    69984           
  Branches       1280     1280           
=========================================
  Hits          45688    45688           
  Misses        23924    23924           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.68% <ø> (ø) 18481 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecdaeb0...201726e. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 7, 2019

Codecov Report

Merging #34711 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34711   +/-   ##
=========================================
  Coverage     65.28%   65.28%           
  Complexity    18481    18481           
=========================================
  Files          1210     1210           
  Lines         69984    69984           
  Branches       1280     1280           
=========================================
  Hits          45688    45688           
  Misses        23924    23924           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.68% <ø> (ø) 18481 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecdaeb0...201726e. Read the comment docs.

@phil-davis
Copy link
Contributor

Backport stable10 #34712

@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants