Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First time login was not properly handled by \OC\User\Session::loginUser #34736

Merged
merged 1 commit into from Mar 13, 2019

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Mar 11, 2019

Description

First time login was not properly handled by \OC\User\Session::loginUser
This PR fixes this.

In addition the method is being made public to allow access.

Motivation and Context

Login shall trigger user initialization on first time login in any case.

How Has This Been Tested?

  • unit tests will follow ...

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #34736 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #34736      +/-   ##
============================================
- Coverage      65.3%    65.3%   -0.01%     
  Complexity    18478    18478              
============================================
  Files          1209     1209              
  Lines         69964    69963       -1     
  Branches       1280     1280              
============================================
- Hits          45689    45687       -2     
- Misses        23903    23904       +1     
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.71% <100%> (-0.01%) 18478 <5> (ø)
Impacted Files Coverage Δ Complexity Δ
lib/private/User/Session.php 79.47% <100%> (ø) 153 <5> (ø) ⬇️
...eratedfilesharing/lib/Controller/OcmController.php 66.06% <0%> (-0.21%) 30% <0%> (ø)
lib/private/Server.php 86.56% <0%> (-0.12%) 253% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e83bc8f...cda98b6. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #34736 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #34736      +/-   ##
============================================
- Coverage      65.3%    65.3%   -0.01%     
  Complexity    18478    18478              
============================================
  Files          1209     1209              
  Lines         69964    69963       -1     
  Branches       1280     1280              
============================================
- Hits          45689    45687       -2     
- Misses        23903    23904       +1     
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.71% <100%> (-0.01%) 18478 <5> (ø)
Impacted Files Coverage Δ Complexity Δ
lib/private/User/Session.php 79.47% <100%> (ø) 153 <5> (ø) ⬇️
...eratedfilesharing/lib/Controller/OcmController.php 66.06% <0%> (-0.21%) 30% <0%> (ø)
lib/private/Server.php 86.56% <0%> (-0.12%) 253% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e83bc8f...cda98b6. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit a37e12c into master Mar 13, 2019
@PVince81 PVince81 deleted the bugfix/fix-first-time-login-in-Session-loginUser branch March 13, 2019 14:16
@PVince81
Copy link
Contributor

@DeepDiver1975 please backport

@skshetry
Copy link
Member

stable10 backport on #34758

@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants