New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First time login was not properly handled by \OC\User\Session::loginUser #34736
First time login was not properly handled by \OC\User\Session::loginUser #34736
Conversation
Codecov Report
@@ Coverage Diff @@
## master #34736 +/- ##
============================================
- Coverage 65.3% 65.3% -0.01%
Complexity 18478 18478
============================================
Files 1209 1209
Lines 69964 69963 -1
Branches 1280 1280
============================================
- Hits 45689 45687 -2
- Misses 23903 23904 +1
Partials 372 372
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #34736 +/- ##
============================================
- Coverage 65.3% 65.3% -0.01%
Complexity 18478 18478
============================================
Files 1209 1209
Lines 69964 69963 -1
Branches 1280 1280
============================================
- Hits 45689 45687 -2
- Misses 23903 23904 +1
Partials 372 372
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@DeepDiver1975 please backport |
|
Description
First time login was not properly handled by \OC\User\Session::loginUser
This PR fixes this.
In addition the method is being made public to allow access.
Motivation and Context
Login shall trigger user initialization on first time login in any case.
How Has This Been Tested?
Types of changes
Checklist:
Open tasks: