[stable10] Protect group share concurrent updates with upsert

[PVince81]

Description

To avoid race conditions happening exactly between the select and
insert/update.

Related Issue

https://github.com/owncloud/enterprise/issues/3167 and #27990

Motivation and Context

How Has This Been Tested?

Automated tests

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• Backport (if applicable set "backport-request" label and remove when the backport was done)

[PVince81]

• check upsert

[codecov]

Codecov Report

Merging #34769 into stable10 will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable10   #34769      +/-   ##
==============================================
+ Coverage       64.19%    64.2%   +<.01%     
  Complexity      19883    19883              
==============================================
  Files            1278     1278              
  Lines           76244    76246       +2     
  Branches         1291     1291              
==============================================
+ Hits            48948    48950       +2     
  Misses          26917    26917              
  Partials          379      379

Flag	Coverage Δ	Complexity Δ
#javascript	53.22% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	65.36% <100%> (ø)	19883 <0> (ø)	⬇️

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Share20/DefaultShareProvider.php	98.33% <100%> (ø)	114 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04843c7...32d622f. Read the comment docs.

[codecov]

Codecov Report

Merging #34769 into stable10 will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable10   #34769      +/-   ##
==============================================
+ Coverage       64.19%    64.2%   +<.01%     
  Complexity      19883    19883              
==============================================
  Files            1278     1278              
  Lines           76244    76246       +2     
  Branches         1291     1291              
==============================================
+ Hits            48948    48950       +2     
  Misses          26917    26917              
  Partials          379      379

Flag	Coverage Δ	Complexity Δ
#javascript	53.22% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	65.36% <100%> (ø)	19883 <0> (ø)	⬇️

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Share20/DefaultShareProvider.php	98.33% <100%> (ø)	114 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04843c7...32d622f. Read the comment docs.

[codecov]

Codecov Report

Merging #34769 into stable10 will decrease coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             stable10   #34769      +/-   ##
==============================================
- Coverage       64.25%   64.24%   -0.01%     
- Complexity      19990    19993       +3     
==============================================
  Files            1281     1281              
  Lines           76663    76648      -15     
  Branches         1307     1307              
==============================================
- Hits            49258    49243      -15     
  Misses          27024    27024              
  Partials          381      381

Flag	Coverage Δ	Complexity Δ
#javascript	53.01% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	65.44% <100%> (-0.01%)	19993 <0> (+3)

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Share20/DefaultShareProvider.php	98.37% <100%> (-0.06%)	120 <0> (-1)
apps/dav/lib/Connector/Sabre/FilesPlugin.php	87.07% <0%> (-0.72%)	77% <0%> (+4%)
lib/private/Server.php	86.65% <0%> (+0.11%)	253% <0%> (ø)	⬇️
apps/dav/lib/CalDAV/Schedule/IMipPlugin.php	81.81% <0%> (+0.42%)	14% <0%> (ø)	⬇️
apps/files_trashbin/lib/Expiration.php	98.27% <0%> (+1.72%)	29% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5ed97c...ee04539. Read the comment docs.

[PVince81]

• alternatives to look into: using upsert (requires deprecation of sqlite and making sure that all DBs are supported)
• analyze potential impact on cluster systems

[PVince81]

• explore the possibility of adding a DB constraint to avoid duplicates

note that even if we only add a constraint without this fix, there is some probability of random error messages

[PVince81]

after discussing with @tomneedham

transactions not a good idea as they could cause deadlocks

• let's try with upsert()
• make sure this properly covered with integration tests

[PVince81]

Upsert added and this is already covered by unit tests and seem to work.

Let's see if it also works in a broader scope (integration/acceptance tests in CI).

[PVince81]

also had a quick test in the UI with a group share and renamed / unshared from self as recipient to test insert and update. the DB entries were updated fine.

[PVince81]

@tomneedham review upsert ?

[PVince81]

master port here: #34952

[PVince81]

adjusted to solve conflict, now that #34951 was merged