Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for File Drop view #34803

Merged
merged 1 commit into from Apr 29, 2019
Merged

Fix for File Drop view #34803

merged 1 commit into from Apr 29, 2019

Conversation

ChrisEdS
Copy link
Contributor

@ChrisEdS ChrisEdS commented Mar 18, 2019

Description

The File Drop view had a scroll bar. This is absolutely unnecessary. This pull request provides enough distance from the info text to the lower edge.

Motivation and Context

The File Drop view had a scroll bar. This is absolutely unnecessary.

How Has This Been Tested?

Tested in Firefox and Chrome

Screenshots:

Mobile view before:

Mobile view before

Mobile view after:

Mobile view after

Browser view before:

Browser view before

Browser view after:

Browser view after

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

Delete unused value
@PVince81
Copy link
Contributor

PVince81 commented Apr 8, 2019

@ChrisEdS did you check that IE11 also works fine ? from what I remember we used to have troubles with IE related to this kind of pages. it was back in the IE8 days though, might not be an issue nowadays

@ChrisEdS
Copy link
Contributor Author

ChrisEdS commented Apr 9, 2019

@PVince81 Works fine on IE, too.

image

@ChrisEdS
Copy link
Contributor Author

@PVince81 Do we bring this to the 10.2.0 release?

@PVince81
Copy link
Contributor

not critical, so no. 10.3 then

@PVince81 PVince81 merged commit 26779ec into master Apr 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-file-drop branch April 29, 2019 13:28
@PVince81
Copy link
Contributor

@ChrisEdS please backport to stable10

@phil-davis
Copy link
Contributor

Backport stable10 #35346

@ChrisEdS
Copy link
Contributor Author

Thank you @phil-davis, I completely missed this task.

@davitol davitol mentioned this pull request Sep 3, 2019
13 tasks
@HariBhandari07
Copy link
Contributor

I guess the file drop view scroll bar appearance depends on the screen size. In my phone scroll bar is shown a little bit
Screenshot_20190905-154935

If you have smaller screen the scroll bar may be visible.

@ChrisEdS
Copy link
Contributor Author

ChrisEdS commented Sep 5, 2019

If you have smaller screen the scroll bar may be visible.

Hello @HariBhandari07, thank you for reporting this. May I ask you which resolution you are using?

@HariBhandari07
Copy link
Contributor

@ChrisEdS the screen resolution of my phone is 720 x 1280 and the screen size is 5.5 inches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants