[stable10] add activity for self unshare action #35193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
Codecov Report
@@ Coverage Diff @@
## stable10 #35193 +/- ##
==============================================
+ Coverage 64.47% 64.48% +0.01%
- Complexity 20070 20074 +4
==============================================
Files 1288 1288
Lines 76936 76955 +19
Branches 1307 1307
==============================================
+ Hits 49606 49626 +20
+ Misses 26949 26948 -1
Partials 381 381
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## stable10 #35193 +/- ##
==============================================
+ Coverage 64.47% 64.48% +0.01%
- Complexity 20070 20074 +4
==============================================
Files 1288 1288
Lines 76936 76955 +19
Branches 1307 1307
==============================================
+ Hits 49606 49626 +20
+ Misses 26949 26948 -1
Partials 381 381
Continue to review full report at Codecov.
|
jvillafanez
approved these changes
May 9, 2019
13 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #35083
Description
This PR publishes an activity entry by listening to self unshare events.
As far as I see, current sharing activities are published in this class by the activity app: https://github.com/owncloud/activity/blob/master/lib/FilesHooks.php. However, IMHO, holding them in files_sharing app is better. So, I added this event listener on files_sharing app. Am I missing something here?
Related Issue
Motivation and Context
whenever a recipient "unshares from self" they should see an activity in their activity stream that says they did so. This would help them to find out why something disappeared from their file tree in case they don't remember doing it.
How Has This Been Tested?
Unit tests and manually with the following steps:
user1,user2)user1touser2user2and unshare the file fromuser2user2should see this action in the activity streamTypes of changes
Checklist: