Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] cli test config key #35320

Merged
merged 1 commit into from
May 24, 2019
Merged

Conversation

paurakhsharma
Copy link
Member

Backport of: #35269

@individual-it
Copy link
Member

(hopefully) unrelated fail in CI, restarting

@codecov
Copy link

codecov bot commented May 24, 2019

Codecov Report

Merging #35320 into stable10 will decrease coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35320      +/-   ##
==============================================
- Coverage       64.91%   64.64%   -0.28%     
  Complexity      20089    20089              
==============================================
  Files            1226     1289      +63     
  Lines           69535    76943    +7408     
  Branches            0     1300    +1300     
==============================================
+ Hits            45142    49738    +4596     
- Misses          24393    26821    +2428     
- Partials            0      384     +384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (?) 0 <ø> (?)
#phpunit 65.78% <ø> (+0.86%) 20089 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/HomePropagator.php 88.88% <0%> (-11.12%) 3% <0%> (ø)
apps/files/lib/Command/Scan.php 71.82% <0%> (-9.19%) 74% <0%> (ø)
core/js/oc-dialogs.js 2.66% <0%> (ø) 0% <0%> (?)
core/js/oc-backbone.js 50% <0%> (ø) 0% <0%> (?)
settings/js/admin-apps.js 6.46% <0%> (ø) 0% <0%> (?)
core/js/config.js 3.33% <0%> (ø) 0% <0%> (?)
apps/files_sharing/js/external.js 77.96% <0%> (ø) 0% <0%> (?)
apps/comments/js/commentmodel.js 100% <0%> (ø) 0% <0%> (?)
core/js/l10n.js 90.54% <0%> (ø) 0% <0%> (?)
core/js/js.js 55.05% <0%> (ø) 0% <0%> (?)
... and 84 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3705219...81a2a5c. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 24, 2019

Codecov Report

Merging #35320 into stable10 will decrease coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35320      +/-   ##
==============================================
- Coverage       64.91%   64.64%   -0.28%     
  Complexity      20089    20089              
==============================================
  Files            1226     1289      +63     
  Lines           69535    76943    +7408     
  Branches            0     1300    +1300     
==============================================
+ Hits            45142    49738    +4596     
- Misses          24393    26821    +2428     
- Partials            0      384     +384
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (?) 0 <ø> (?)
#phpunit 65.78% <ø> (+0.86%) 20089 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Cache/HomePropagator.php 88.88% <0%> (-11.12%) 3% <0%> (ø)
apps/files/lib/Command/Scan.php 71.82% <0%> (-9.19%) 74% <0%> (ø)
core/js/oc-dialogs.js 2.66% <0%> (ø) 0% <0%> (?)
core/js/oc-backbone.js 50% <0%> (ø) 0% <0%> (?)
settings/js/admin-apps.js 6.46% <0%> (ø) 0% <0%> (?)
core/js/config.js 3.33% <0%> (ø) 0% <0%> (?)
apps/files_sharing/js/external.js 77.96% <0%> (ø) 0% <0%> (?)
apps/comments/js/commentmodel.js 100% <0%> (ø) 0% <0%> (?)
core/js/l10n.js 90.54% <0%> (ø) 0% <0%> (?)
core/js/js.js 55.05% <0%> (ø) 0% <0%> (?)
... and 84 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3705219...81a2a5c. Read the comment docs.

@individual-it individual-it merged commit 3566cfc into stable10 May 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-cli-Test-configKey branch May 24, 2019 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants