Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipOnEncryption annotation added on feature test #35384

Merged
merged 1 commit into from
May 31, 2019
Merged

skipOnEncryption annotation added on feature test #35384

merged 1 commit into from
May 31, 2019

Conversation

cedens28
Copy link
Contributor

@cedens28 cedens28 commented May 31, 2019

Description

This test fails when encryption is enabled

Scenario: share with user when username contains capital letters
    Given these users have been created:
      | username |
      | user1    |
    When user "user0" shares file "/welcome.txt" with user "USER1" using the sharing API
    Then the OCS status code should be "100"
    And the HTTP status code should be "200"
    And the fields of the last response should include
      | share_with  |  user1       |
      | file_target | /welcome.txt |
      | path        | /welcome.txt |
      | permissions | 19           |
      | uid_owner   | user0        |
    And user "user1" should see the following elements
      | /welcome.txt |

Related Issue

encryption owncloud/encryption#126

Motivation and Context

Test fails when encryption is enabled

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #35384 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35384   +/-   ##
=========================================
  Coverage     65.53%   65.53%           
  Complexity    18648    18648           
=========================================
  Files          1218     1218           
  Lines         70549    70549           
  Branches       1288     1288           
=========================================
  Hits          46236    46236           
  Misses        23936    23936           
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.69% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.89% <ø> (ø) 18648 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb0c93d...6acc12c. Read the comment docs.

Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@phil-davis phil-davis merged commit 7a4e13d into owncloud:master May 31, 2019
@phil-davis
Copy link
Contributor

@HariBhandari07 please make a backport to stable10

@cedens28
Copy link
Contributor Author

backport on #35393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants